Background

Proposed solution

  • The gist of the InstallerTest class should be moved into a new InstallerTestBase class provided by Simpletest, so as to make it a formal base class for all interactive installer tests + advance on it.
  • The resulting minimal Drupal\system\Tests\InstallerTest class should be moved into the Drupal\system\Tests\Installer\ namespace.
CommentFileSizeAuthor
#3 test.installer.3.patch3.72 KBsun

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Postponed

For now this is postponed on the parent issue.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Postponed » Active

Back to Active.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Assigned: Unassigned » sun
Status: Active » Needs review
StatusFileSize
new test.installer.3.patch3.72 KB

Here we go.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

I need to change a bit of the moved code over in #2176621: Remove global $databases, so it would be great if we could get this patch here committed first. :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Great - let's get this done.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

3: test.installer.3.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Any chance to move forward here?

There are three issues that need to touch the InstallerTest code, so it would be great if we could move the file first — otherwise, this patch here would have to be re-rolled from scratch...

#318975: Remove confirmation page after installation
#1351352: Distribution installation profiles are no longer able to override the early installer screens
#2196241: Remove string translation services from TestBase container

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

3: test.installer.3.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

No love? :-)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

This looks fine to me, as it's basically just moving code around. On IRC, I asked for a few other examples of what other installer tests we might use this base class for, and sun cited a few examples, like installer + translation tests, as well as tests for install profiles like e.g. #1351352: Distribution installation profiles are no longer able to override the early installer screens Sounds good to me.

Committed and pushed to 8.x. Thanks!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Sorry, I just noticed an oversight in this patch:

#2206417: Bogus tests without test methods are reported as successful tests

We'll fix it over there.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.