I'm getting this error when go to the page: admin/structure/features/*/recreate.
"PHP warning: Only variables should be passed by reference in skinr_skin_features_export_options() (line 46 of sites/all/modules/contrib/skinr/skinr.features.inc)".

CommentFileSizeAuthor
#1 skinr-variables-only-reference-2175389-0.patch763 byteskendouglass
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kendouglass’s picture

kendouglass CreditAttribution: kendouglass commented
FileSize
skinr-variables-only-reference-2175389-0.patch763 bytes

This patch was made on skinr-7.x-2.0-beta1+27-dev. It fixes the issue.

kendouglass’s picture

kendouglass CreditAttribution: kendouglass commented
Status: Active » Needs review
kendouglass’s picture

kendouglass CreditAttribution: kendouglass commented
Issue summary: View changes
kendouglass’s picture

kendouglass CreditAttribution: kendouglass commented
Issue summary: View changes
kendouglass’s picture

kendouglass CreditAttribution: kendouglass commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 1: skinr-variables-only-reference-2175389-0.patch, failed testing.

raveendrab’s picture

raveendrab CreditAttribution: raveendrab commented

Similar error is appearing in skinr_ui_admin.inc line 445. This erroris coming while listing the skin configurations.
Perhaps this is in connection with php 5.4 compatibility.

Strict warning: Only variables should be passed by reference in skinr_ui_admin_skins() (line 445 of /usr/local/share/drupal7/modules/skinr/skinr_ui.admin.inc).

kendouglass’s picture

kendouglass CreditAttribution: kendouglass commented

In my case, this error is with PHP 5.3.3.

More info:
I also, get a white screen and this error when clicking "Edit skin" in the blocks contextual links drop-down:
PHP Fatal error: [] operator not supported for strings in /home/drupal/drupal7/sites/example.com/themes/omega/omega/template.php on line 337

The current parent theme I'm using is omega-7.x-4.2+2-dev. If I comment out line 337 mentioned in that error message, then all seems to work well.

I'm reporting this here because this error only happens when skinr is enabled.
I'll also add an issue for the omega theme project.

  • Commit eac46d4 on 7.x-2.x by moonray: 
    Issue #2175389 by moonray, kendouglass: Fixed passed by reference PHP...
moonray’s picture

moonray CreditAttribution: moonray commented
Status: Needs work » Fixed

Most of these were already fixed in previous updates. The above commit fixes the last remaining instances.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.