Updated: Comment 0

Problem/Motivation

We needed to fork doctrine/common for a while.

Proposed resolution

Undo it.

most of these noise is comming from the recent composer version.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#10 doctrine-2173719.patch27.97 KBdawehner
#8 common-2173719-8.patch24.82 KBtim.plunkett
doctrine_common.patch35.94 KBdawehner

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good to me.

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Major

Bumping status a bit, good to keep things like this straight.

dries’s picture

dries commented

This appears to add a PSR-4 class loader which would make this major.

dawehner’s picture

dawehner
Primary language German
commented

@Dries
The current composer version always uses a PSR-4 class loader, given that PSR-0 is just a subset.
You cannot specify to use a PSR-0 only class loader, though as long we don't change anything inside drupal itself, it won't register the namespaces in a PSR-4 way.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Just an innocent question, please do not stab me. Is it possible to do this without upgrading composer at the same time? Makes the patch a no-brainer to get in.

dawehner’s picture

dawehner
Primary language German
commented

See #2172235-9: Upgrade Twig to 1.15.* from 1.12.*

That was my honest opinion here.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

#2175447: Update composer to latest version

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new common-2173719-8.patch24.82 KB
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

Ok, cool, #2175447: Update composer to latest version is in, this one will need a small re-roll. Feel free to bump back to RTBC once that's done.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new doctrine-2173719.patch27.97 KB

Rerolled.

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward to me.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Wondering if we can just bump this up to a straightforward version requirement here: #2375997: Avoid tying Drupal 8's composer.json to specific package commits.