Remove deprecated timer_* functions.

CommentFileSizeAuthor
#4 drupal8.dep-timer.4.patch3.93 KBsun
#2 drupal8.dep-timer.2.patch3.94 KBsun
drupal8.dep-timer.0.patch844 bytessun

Comments

Status: Needs review » Needs work

The last submitted patch, drupal8.dep-timer.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal8.dep-timer.2.patch3.94 KB

Status: Needs review » Needs work

The last submitted patch, 2: drupal8.dep-timer.2.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal8.dep-timer.4.patch3.93 KB

Sorry, created patch on wrong branch ;)

yesct’s picture

yesct commented
Related issues: +#2060201: Docblock errors in deprecated timer_*() docblocks

do we need to check contrib?

will it need a change record?

#2158871: [Policy, no patch] Clearly denote when @deprecated code is slated to be removed might be relevant.

will conflict with #2060201: Docblock errors in deprecated timer_*() docblocks

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

We do already have one with https://drupal.org/node/1969828

For 8.1 we could maybe think of reusing http://symfony.com/doc/current/components/stopwatch.html

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Regarding StopWatch, see #1936640: Replace the Timer component with Symfony Stopwatch

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Remove deprecated timer_* functions » Change notice: Remove deprecated timer_* functions
Priority: Normal » Major
Status: Fixed » Active
Issue tags: +Needs change record

Oopsie.

j4’s picture

j4 commented
Status: Active » Needs review
Related issues: +#1936640: Replace the Timer component with Symfony Stopwatch

Edited the Change Record and added a mention of pushing replacement of the timer with Symphony Stopwatch to Drupal 9.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Needs work
Issue tags: +Missing change record

Thanks! We should also update the change record to say that the procedural functions have been removed, since the patch removes them.

Tagging "Missing change record", as completing the change record updates here blocks a beta: #2083415: [META] Write up all outstanding change notices before release

ParisLiakos’s picture

ParisLiakos commented
Title: Change notice: Remove deprecated timer_* functions » Remove deprecated timer_* functions
Priority: Major » Normal
Status: Needs work » Fixed
Issue tags: -Needs change record, -Missing change record

Change notice updated

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.