We need to do this (just like FormBase) in order to not end up with a >400K serialized $form and $form_state in the database.

CommentFileSizeAuthor
#1 2171757.patch1.03 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Active » Needs review
FileSize
2171757.patch1.03 KB

.

Status: Needs review » Needs work

The last submitted patch, 1: 2171757.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review

1: 2171757.patch queued for re-testing.

yched’s picture

yched CreditAttribution: yched commented

Sounds totally reasonable, but would be best if @tim.plunkett or @dawehner RTBC'ed this one.

Status: Needs review » Needs work

The last submitted patch, 1: 2171757.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review

1: 2171757.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Given that this form is used for exposed form, this is even more important than most other forms

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 9f57eec and pushed to 8.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Priority: Normal » Major

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.