Updated: Comment 0
While trying to integrate the webprofiler toolbar and drupal you have to swap out the event dispatcher, so you can track what is going on in there.
Sadly some places in core does not typehint the Interface but the actual class which makes that impossible.

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#4 2171655-event_dispatcher.patch4.17 KBdawehner
#1 2171655-event_dispatcher-1.patch4.34 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 2171655-event_dispatcher-1.patch4.34 KB

I just found the following two instances, probably caused by the first usage of the event dispatcher in drupal itself.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

You are correct.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll 
git ac https://drupal.org/files/issues/2171655-event_dispatcher-1.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4449  100  4449    0     0   1033      0  0:00:04  0:00:04 --:--:--  1326
error: patch failed: core/lib/Drupal/Core/Config/ConfigFactory.php:9
error: core/lib/Drupal/Core/Config/ConfigFactory.php: patch does not apply
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2171655-event_dispatcher.patch4.17 KB

Rerolled

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll +Quick fix

Re-RTBCed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 09d4037 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.