\Drupal\migrate\Plugin\migrate\source\SourcePluginBase::prepareRow() invokes two Migrate hooks, but instead of providing the hook arguments as an array, it passes on objects. This came to light when testing #1972304-51: Add a HookEvent.

This issue blocks

CommentFileSizeAuthor
#1 drupal_2170989_1.patch1005 bytesXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Assigned: Xano » Unassigned
Status: Active » Needs review
FileSize
drupal_2170989_1.patch1005 bytes
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

We may not need tests for this if #2170991: Migrate provides invalid arguments when invoking hooks/type hint array arguments in ModuleHandlerInterface gets fixed.

chx’s picture

chx CreditAttribution: chx commented
Project: Drupal core » IMP
Version: 8.x-dev »
Component: migration system » Code
Status: Needs review » Fixed

Committed, thanks!

chx’s picture

chx CreditAttribution: chx commented
Project: IMP » Drupal core
Version: » 8.x-dev
Component: Code » migration system
Status: Fixed » Reviewed & tested by the community

OK so this needs to go into core as well.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Priority: Normal » Major

Suppose this hooks are not covered with tests at all

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Reviewed & tested by the community » Closed (duplicate)

Let's combine this with #2170991: Migrate provides invalid arguments when invoking hooks/type hint array arguments in ModuleHandlerInterface.