The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.In core/modules/search/lib/Drupal/search/Form we have several classes.
There is SearchBlockForm, which is used for searching from the search block.
And there is SearchPageForm, which is used for searching from the search page.
I cannot figure out what SearchForm is used for though. I think it is leftover cruft and should be removed? I grepped through Core and couldn't find it being used anywhere.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2170635.patch | 3.4 KB | jhodgdon |
Comments
Comment #1
jhodgdonJust to confirm, here is a patch to remove the file.
Comment #2
ianthomas_ukSee also #2042807-107: Convert search plugins to use a ConfigEntity and a PluginBag
tim.plunkett's sandbox had shown SearchPageForm.php as being a rename of SearchForm.php, but when I rerolled into a single commit it was a new file. I assumed it was just git being weird, but maybe it was an intentional change.
Comment #3
jhodgdonOK that explains where it came from. Assuming the tests pass, we should get rid of it again. I am pretty sure it isn't being used (via grep).
Comment #4
tim.plunkettI was trying to rename SearchForm to SearchPageForm, but it must have gotten busted in a reroll, and never was removed.
Comment #5
tim.plunkettComment #6
alexpottCommitted 0c7e0f7 and pushed to 8.x. Thanks!