Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#6 | 2170519-testbase-doc-6.patch | 1002 bytes | longwave |
#1 | 2170519-testbase-doc-1.patch | 930 bytes | kim.pepper |
Comments
Comment #1
kim.pepperComment fixes.
Comment #2
damiankloip CreditAttribution: damiankloip commentedComment #3
jhodgdonYou could fix the comment wrapping -- that comment does not have to be so many lines?
Comment #4
jhodgdonComment #5
kim.pepperHow do you propose to fix the wrapping? Break the namespace up?
Comment #6
longwaveWe can reword the comment as per the attachment to make it not look quite so strange in code.
Comment #7
jhodgdonOh sorry, my bad -- you are right that the comment wouldn't all fit on one line. I must have been halucinating or had my editor/terminal window mis-sized there.
I like the wording in #6 better though -- active rather than passive voice is always preferable. Thanks!
Comment #8
jhodgdonThere is an "avoid commit conflicts" patch on #1862202: Objectify the language system that touches this same file, and although they don't seem to conflict, I'm being extra cautious lately and will wait to commit this until that one lands. And then I'll probably have to wait about a week during our "only commit major/critical patches the week before the next alpha" break. Sorry...
Comment #9
jhodgdonThe other patch landed and we're out of "critical/major" week, so I committed this to 8.x. Thanks again!