Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
search.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Jan 2014 at 17:15 UTC
Updated:
29 Jul 2014 at 23:16 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonI'm getting the message on the User search tab but not the Node search tab.
Comment #2
jhodgdonOK. I've tracked this down... What happens is that for User search, \Drupal\search\Form\SearchPageForm::submitForm() is called as the submit function, and that does the "please enter some keywords" message if there isn't anything there. But for Node search, \drupal\node\Plugin\Search\NodeSearch::searchFormSubmit() is called as the submit function, and that doesn't have the message.
I made a patch to fix this but it involves calling the deprecated form_set_error() function. Yuck. The problem is that NodeSearch is not a form builder so it doesn't have access to the form builder set error function.
Comment #3
jhodgdonWe need to redo how errors and warnings are handled in searching on #1366020: Overhaul SearchQuery; make search redirects use GET query params for keywords, which will hopefully take care of this problem, so I'm postponing this until that one is done.
Comment #4
jhodgdonThis was fixed and tested in #1366020: Overhaul SearchQuery; make search redirects use GET query params for keywords.