Improve docblocks in MigrateSqlSourceTestCase, as far as for now is the only "documentation" for testing migration source plugins.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | imp-2169101-source-tests-docs-9.patch | 1.78 KB | penyaskito |
| MigrateSqlSourceTestCaseDocs.patch | 1.4 KB | penyaskito |
Comments
Comment #2
penyaskitoMigrateSqlSourceTestCaseDocs.patch queued for re-testing.
Comment #5
penyaskitoMigrateSqlSourceTestCaseDocs.patch queued for re-testing.
Comment #7
penyaskitoMigrateSqlSourceTestCaseDocs.patch queued for re-testing.
Comment #8
jhodgdonLooks pretty good, thanks!
Can you fix the paragraph wrapping?
If you want this as two paragraphs, put a blank line in between. If it is one, wrap it as one.
Also,
This doesn't have docs?
And
Needs a blank line before the @var.
Comment #9
penyaskito#8.1: Left as one paragraph.
#8.2: Until @chx and @andypost explained I had no idea what this meant.
#8.3: Fixed, sorry.
Comment #10
jhodgdonGreat!
I need someone else to verify this change:
No idea if that is correct or not.
Everything else looks OK. Some of the wording is slightly awkward, but it's clear enough.
Comment #11
chx commentedThat is correct. Comment was the first and that remained, well caught.
Comment #12
jhodgdonOK, thanks! I'll get this committed sometime soon unless one of the other committers beats me to it.
Comment #13
jhodgdonThanks again! Committed to 8.x.