Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
documentation
Priority:
Minor
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
6 Jan 2014 at 23:45 UTC
Updated:
29 Jul 2014 at 23:16 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonLooks good to me. Thanks!
Comment #2
webchickReducing priority since this isn't a functional bug.
Also tagging, as it may make sense to batch this with other changes that cause other patches to be re-rolled.
Comment #3
jhodgdonAssigning to webchick for commit, since I'm not sure what the schedule is for disruptive patches.
Comment #4
longwaveOriginal patch no longer applies, here's an updated one with even more fixes I missed the first time round.
Comment #7
longwaveComment #8
longwaveRerolled.
Comment #9
jhodgdonI carefully checked the latest patch and agree with all of the indentation changes. However, there was one finger slip:
Comment #10
longwaveWhoops, sorry about that.
Comment #11
jhodgdonThanks!
Comment #12
alexpottindentation_3.patch no longer applies.
Comment #13
martin107 commentedReRoll
Comment #14
martin107 commentedComment #15
lhangea commentedthe patch applied cleanly
Comment #16
alexpottindentation_13.patch no longer applies.
Comment #17
martin107 commentedReroll..
next disruptive patch period is 20th to 23rd
Comment #18
jhodgdonPatch doesn't apply; needs reroll again. Disruptive patch window is today and tomorrow!
Comment #19
martin107 commentedReroll... lots of places where head has already been corrected. Lots of code moving file... lots of places to go wrong... lets see what testbot has to say
Comment #20
martin107 commentedComment #21
jhodgdonThanks! This all looks correct to me. We should get it in before it doesn't apply again.
Comment #22
dries commentedCommitted to 8.x. Thanks.