Updated: Comment #2

Problem/Motivation

EntityTest::label() overrides Entity::label() in case $info->getKey('laebl') == 'name' is TRUE. This is apparently a typo and thus will never be TRUE (unless an entity type would incorrectly specify a laebl entity key). Since tests pass although the code in this condition will never be reached, they should also pass without the code.

Proposed resolution

Remove EntityTest::label()

Remaining tasks

Review patch.

User interface changes

None.

API changes

None.

Comments

tstoeckler’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new1009 bytes
tstoeckler’s picture

Issue summary: View changes

Updated issue summary. I had the logic reversed. The patch is still valid, though.

berdir’s picture

Status: Needs review » Needs work

The last submitted patch, 1: 2167639-1-entity-test-label.patch, failed testing.

tstoeckler’s picture

Issue summary: View changes
tstoeckler’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new1012 bytes

Re-rolled. This was broken by the entityInfo() -> getEntityType() patch.

berdir’s picture

Status: Needs review » Reviewed & tested by the community

Bye, bye :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Yay less code. :)

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.