If JSHint was integrated to the testbot all the patch would have been red for a while. Needs to be fixed.

Fixes the following: 

core/misc/autocomplete.js: line 74, col 19, Possible strict violation.

core/modules/edit/js/views/FieldToolbarView.js: line 31, col 64, Missing semicolon.

the strict violation needs a jshint specific comment to fix, no other way around that one. It's a valid way to take care of this, see: https://github.com/jshint/jshint/issues/621

CommentFileSizeAuthor
core-js-jshint-errors.patch1 KBnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, core-js-jshint-errors.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review

core-js-jshint-errors.patch queued for re-testing. https://qa.drupal.org/pifr/test/699378

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Priority: Critical » Normal

Um this is not critical. :)

Also, that's basically the equivalent of putting @ in front of a function name in PHP. Is that really the only way to solve this?

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented

unfortunately yes.

Once jshint drops the checks for "this" we'll be able to remove the comment. That or we need to refactor the whole autocomplete stuff.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Darn. Ok then...

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.