#2001206: Replace drupal_container() with Drupal::service() removed the drupal_container() function (committed 22nd Dec)
#2068471: Normalize Controller/View-listener behavior with a Page object added a call to drupal_container() (committed 2nd Jan)

CommentFileSizeAuthor
#5 interdiff.txt763 bytesmtift
#5 drupal_container-2167517-5.patch1.5 KBmtift
#1 drupal_container.2167517.patch1.36 KBmtift

Comments

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
StatusFileSize
new drupal_container.2167517.patch1.36 KB

Here is a patch. It also removes one reference to a non-existent drupal_container().

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
Status: Active » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

RTBC if green.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Needs work

The AdminNegotitator already takes care about the admin theme logic, so we should really kill that code. This was certainly a reroll conflict.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
StatusFileSize
new drupal_container-2167517-5.patch1.5 KB
new interdiff.txt763 bytes

Thanks @dawehner. I think the attached patch addresses your comments.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review

Let's see if the bot likes it.
Patch looks good!

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

I swear that is THE most stubborn function ever.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Ok, I guess that also explains why tests aren't blowing up over this atm.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.