Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
Garland theme
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
1 Feb 2008 at 07:20 UTC
Updated:
24 Mar 2008 at 23:33 UTC
Jump to comment: Most recent file
Right now, status messages In Garland look pretty crappy, especially if differently styled status messages are shown together on one page.
The enclosed patch corrects the various margins and paddings both for LTR and RTL. Also, I improved the positioning of ul bullets (which are especially prominent in menu items).
I guess I don't have to be more detailed as the pictures say everything.
LTR has been tested in Firefox 2.0.0.11, IE 7 and Opera 9.25. RTL remains to be tested.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | orange-warning.png | 17.41 KB | pancho |
| #1 | menu.png | 18.98 KB | pancho |
| messages.png | 48.97 KB | pancho | |
| messages2.png | 51.98 KB | pancho | |
| messages3.png | 49.08 KB | pancho |
Comments
Comment #1
panchoAnd here's a screenshot for the menu items.
Comment #2
Stefan Nagtegaal commentedI like what your doing here...
But to make things even better, make the color of the warning a little less black.. Perhaps #333 is better for that, furthermore this is really nice...
If you could change the point I mentioned above, this is really RTBC! :-)
Comment #3
panchoRather I'd use a dark orange (#F0C020) for warnings to match the styles of error and status messages. Attached is another screenshot. If I get some positive reviews for the dark orange, I'll reroll the patch with this.
Comment #4
damien tournoud commented+1 for the looks, with dark orange.
For the patch: note that there are already two declarations of ".messages" (once along with .preview) and a declaration of ".messages ul" in the style sheets. All this could and should be all in one place.
Comment #5
Stefan Nagtegaal commentedAssigning myself...
Comment #6
Stefan Nagtegaal commentedThere is a patch for this at http://drupal.org/node/231115..
Please review it there, and report back to me (using that issue, not this one)..
I'll close this bug report once the patch http://drupal.org/node/231115 is in..
Comment #7
Stefan Nagtegaal commentedI investigated this, and I'm absolutely positive that the best way to color this is already in core.
I'm marking this "By Design"...
Comment #8
Stefan Nagtegaal commentedfixed by http://drupal.org/node/231115
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.