Missing table alias in comment_render function breaks hook_db_rewrite_sql [#216504]

While updating a module for D6, I ran into an error in my hook_db_rewrite_sql where the primary table is the comments table ('c'):

user warning: Unknown table 'c' in where clause query: SELECT COUNT(*) FROM comments...

This is because of the following in the comment_render function in comments.module:

      $query_count = 'SELECT COUNT(*) FROM {comments} WHERE nid = %d';
      ...
      $query_count = db_rewrite_sql($query_count, 'c', 'cid');

So I've attached a patch that adds the 'c' table alias to the $query_count variable.

Comment	File	Size	Author
#11	comment-db_rewrite_sql-fix-216504-11.patch	1.15 KB	webchick
#6	comment-db_rewrite_sql-fix-216504-6.patch	1.15 KB	webchick
#4	comment-db_rewrite_sql-fix-216504-3.patch	1.71 KB	webchick
#1	comment_render_table_alias_1.patch	1.15 KB	mcarbone
	comment_render_table_alias.patch	937 bytes	mcarbone

Comments

Comment #1

mcarbone commented 31 January 2008 at 23:15

Status	File	Size
new	comment_render_table_alias_1.patch	1.15 KB

Oops, I missed a spot to add the alias. New patch attached.

Comment #2

mcarbone commented 6 February 2008 at 18:33

Title:

Missing table alias in comment_render function

» Missing table alias in comment_render function breaks hook_db_rewrite_sql

This is a very tiny fix -- without it, hook_db_rewrite_sql cannot work with the comments table. It should be easy to review.

Comment #3

webchick

she/they

English

Vancouver 🇨🇦

commented 7 April 2008 at 08:03

Can confirm the bug, and the fix. Moving to critical, since it breaks db_rewrite_sql() for comments.

To reproduce, stick the following in your module and view a node page with some comments as a non-admin user:

function example_db_rewrite_sql($query, $primary_table = 'n', $primary_field = 'nid', $args = array()) {
  if ($primary_field == 'cid') {
    $return['join'] = "INNER JOIN {comments} c2 ON $primary_table.cid = c2.cid";
    $return['where'] = "$primary_table.status = c2.status";
    return $return;
  }
}

First problem:

user warning: Unknown column 'c.status' in 'where clause' query: pager_query /* peon : pager_query */ SELECT COUNT(*) FROM comments INNER JOIN comments c2 ON c.cid = c2.cid WHERE (c.status = c2.status) AND ( nid = 1 AND status = 0) in /Applications/MAMP/htdocs/6x/modules/comment/comment.module on line 989.

(fixed w/ mcarbone's patch)

Second problem:

user warning: Column 'nid' in where clause is ambiguous query: pager_query /* peon : pager_query */ SELECT COUNT(*) FROM comments c INNER JOIN comments c2 ON c.cid = c2.cid WHERE (c.status = c2.status) AND ( nid = 1 AND c.status = 0) in /Applications/MAMP/htdocs/6x/modules/comment/comment.module on line 989.

fixed with this one, which includes mcarbone's patch.

Also tested recent comments block, etc. and this appears to be working. Could use a couple sets of eyes, though.