Updated: Comment #N

Problem/Motivation

What user_node_load() does is already marked as deprecated and it executes a query for something that you shouldn't use and the current implementation of #597236: Add entity caching to core can't cache.

We have $node->author during rendering as the @todo says, and we have getAuthor() and getAuthorId() on the interface.

Let's see if something still needs it.

Proposed resolution

Remove it, see what happens.

Remaining tasks

User interface changes

API changes

$node->name goes away.

CommentFileSizeAuthor
#1 user-node-load-2164715-1.patch1.05 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new user-node-load-2164715-1.patch1.05 KB

And here's a patch. No idea if this will work already.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Plain and simple.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Yay, less code!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.