in #2161591: Change default active config from file storage to DB storage we're discussing replacing the active store with a queryable key value based store. Whilst reviewing the relevant code I realised we could swap out calls to Drupal::config()->get() with a call to ConfigFactory::readMultiple().

This should help us leverages the static cache in ConfigFactory better.

CommentFileSizeAuthor
#4 2163371_4.patch4.47 KBalexpott
#3 2163371.3.patch4.47 KBalexpott
#3 1-3-interdiff.txt703 bytesalexpott
#1 2163371.1.patch4.62 KBalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Related issues: +#2161591: Change default active config from file storage to DB storage
StatusFileSize
new 2163371.1.patch4.62 KB

Here's a patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
StatusFileSize
new 1-3-interdiff.txt703 bytes
new 2163371.3.patch4.47 KB

Ok. reading the code realised that the patch in #1 would break count queries on empty result sets.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2163371_4.patch4.47 KB

A dot free patch

Anonymous’s picture

Anonymous (not verified) commented

looks good to me. alexpott++

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

To me as well.

It's not as much about the static cache but the persistent cache in the cached storage controller, a getMultiple() is a single getMultiple() on the cache backend, which is more efficient.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.