Updated: Comment #0
sun rightfully complained in #1996238: Replace hook_library_info() by *.libraries.yml file that the Text Editor module's library definitions contain a setting that is dynamically generated, which violates the immutability principle of libraries.
While working on removing this, I noticed that this setting was nonessential: thanks to Drupal.url() we can generate this URL on the client-side! That both fixes this problem and results in less data on the wire! We already use this technique in many other places in Drupal core.
Use Drupal.url() instead of drupalSettings.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | editor_library_dynamic_setting-2161763-1.patch | 1.61 KB | wim leers |
Comments
Comment #1
wim leersComment #2
nod_That works :)
Comment #3
sunIf possible, it would be great to defer these commits on #1996238: Replace hook_library_info() by *.libraries.yml file, because that one is an utter pain to re-roll.
Comment #4
wim leers#3 is not yet ready, and it allows you to simply *remove* several hunks from that patch, so I respectfully disagree.
Comment #5
webchick#1996238: Replace hook_library_info() by *.libraries.yml file was already broken by it looks like many other things, so will need a re-roll in any event. Getting this one in in the meantime.
Committed and pushed to 8.x. Thanks!
Comment #6
wim leers