Update to Symfony 2.4.1

If we want to provide long term support for Drupal 8 we might be only able to use the LTS releases of symfony? So 2.6 is the next one.

Don't get me wrong, there are a lot of features we could use, like the RequestStack.

This failures are presented by https://github.com/symfony/symfony/commit/65814bae27d6fdb9501a4efd07e6b9...

This was originally caused by https://github.com/symfony/symfony/pull/8882 so here are two fixes.

Just for the sake of understanding API usage,

    $server = $request->server->all();
    $server['HTTP_HOST'] ;

is now how we get the http_host? There's nothing like ->get('HTTP_HOST') or somesuch?

@larowlan told me to use $request->getHost() in his review in #1862202-294: Objectify the language system, see the resulting interdiff in #295. Will this be affected by this? If not, then I think that is how you can get the host without port.

Moving down to needs review for that question.

Daniel, can you confirm?

Aye, aye sir. All functions in the symfony request calls getHttphost(). example: getUri->getSchemeAndHttpHost,

Ups, thanks berdir

Note: the previous patch also updated all other dependencies (guzzle, phpunit ...) so this should just update symfony and applies the interdiff of the previous patch.

15: symfony-2161397.patch queued for re-testing.

Committed and pushed to 8.x. Thanks!

Crap, sorry, scratch that. This conflicts with #1862202: Objectify the language system which is a) tagged Avoid commit conflicts, b) a blocker to the remainder of stuff needed to rip out the variable system, c) a critical beta blocker. So I've rolled this one back, and marking postponed on that one, since as far as I can tell this issue doesn't block anything specific in the path of a D8 beta.

REVERTED for now.

Well, that is sad as functionality from 2.4 could be used potentially in many places.

Now #1862202: Objectify the language system is in core, so update status.

15: symfony-2161397.patch queued for re-testing.

Reroll.

26: symfony_2.4.1-2161397.patch queued for re-testing.

It is a bit sad that it does not work anymore, maybe this time.

#2175447: Update composer to latest version

Sadly this does not help the patch at all, it just not runs on the testbot but does on my local system.

@dawehner:

I am really sorry about this being reverted :(

I tried to see whether I was able replicate the error and I actually got one failure right before completing the installation (after inserting admin user name/password):

Fatal error: Class 'Symfony\Component\PropertyAccess\PropertyAccess' not found in /var/www/test.dd/core/vendor/symfony/validator/Symfony/Component/Validator/ValidatorBuilder.php on line 347

See the attached screenshot for the full stack trace.

I did a very quick and dirty merge as the patch did not apply anymore, so I might have messed up things. However here you can find my local code:

http://drupalcode.org/sandbox/plach/1719670.git/shortlog/refs/heads/symf....

Too late to dig further into it now, hope this helps :)

plach!!! I guess install via drush is still kinda different.

Another try, actually two additional tries.

Green again!

Awesome!

This is awesome. Thank you for the update. Can we have review only patch without all the composer updated code?

Sure

Ok, for real this time. :)

Committed and pushed to 8.x. Thanks!

Thank you!