Remove $reindex param in search_reindex()

This is a cosmetic issue for users of the API, there's no broken or missing functionality, so I'd say it's minor rather than normal.

It's also an API change, so would be against the policy to include in Drupal 8 at this stage. See https://drupal.org/node/2045345

I'm not sure what to do with this issue though - should we ask for permission for the api change, bump it to D9, or mark as won't fix?

I changed the status because it is against the current policy to commit this to 8.x, so there seemed little point reviewing it for 8.x until that could be resolved.

Does it block release? -> No -> Is it a big deal? -> No -> Do not propose an API change.

Perhaps there should be a third question in there: "Are we confident that we have updated all calls to this API from Drupal core and contrib?" i.e. for critical / major issues we can change an API and contrib has to keep up, but if we want to change an API for normal or minor issues then we also need to provide patches for any affected contrib code. This is getting off topic though...

I'm not necessarily opposed to removing completely dead code, but I'm wondering why/when the code died and whether or not that's a bug.. because while I can confirm that the D8 version of search_reindex() contains no reference to that variable, the D7 version definitely did:

    // Don't remove links if re-indexing.
    if (!$reindex) {
      db_delete('search_node_links')->condition('sid', $sid)->condition('type', $module)->execute();
    }

So what's up with that?

Awesome, thanks, that totally makes sense.

Now it just needs to apply again. :D

Ok, great.

Committed and pushed to 8.x. Thanks!

Marking for a brief change notice.