Part of #1839338: [meta] Remove drupal_set_*() drupal_add_*() in favour of #attached/response for out-of-band stuff.

CommentFileSizeAuthor
#3 2160603-diff-1-3.txt671 bytesvijaycs85
#3 2160603-remove-drupal_add_js-bartik-3.patch649 bytesvijaycs85
#1 2160603-remove-drupal_add_js-bartik-1.patch669 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
2160603-remove-drupal_add_js-bartik-1.patch669 bytes

Initial patch...

Status: Needs review » Needs work

The last submitted patch, 1: 2160603-remove-drupal_add_js-bartik-1.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
FileSize
2160603-remove-drupal_add_js-bartik-3.patch649 bytes
2160603-diff-1-3.txt671 bytes

Fixing fatal...

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Reviewed & tested by the community

Man, color.inc is one strange animal…

Patch is as good as it'll get.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.