Part of #1839338: [meta] Remove drupal_set_*() drupal_add_*() in favour of #attached/response for out-of-band stuff.

The culprit:

function test_page_test_page() {
  drupal_add_js(array('test-setting' => 'azAZ09();.,\\\/-_{}'), array('type' => 'setting'));
  return array(
    '#title' => t('Test page'),
    '#markup' => t('Test page text.'),
  );
}
CommentFileSizeAuthor
#2 interdiff.txt754 bytesWim Leers
#2 2160599-remove-drupal_add_js-system-2.patch870 bytesWim Leers
#1 2160599-remove-drupal_add_js-system-1.patch869 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Title: Remove drupal_add_js() from system.module » Remove drupal_add_js() from system module
Status: Active » Needs review
FileSize
2160599-remove-drupal_add_js-system-1.patch869 bytes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Reviewed & tested by the community
FileSize
2160599-remove-drupal_add_js-system-2.patch870 bytes
interdiff.txt754 bytes

Looks great: does not introduce another drupal_render($attached) call like the other patches :)

This changes an attachment that is being tested, so since it's green, it obviously doesn't break anything.

One nitpick: a missing trailing comma. Added that.

RTBC.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented

Thanks for clean up @Wim Leers and +1 to RTBC.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.