Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

Status: Active » Needs review
FileSize
802 bytes

Initial patch...

Wim Leers’s picture

Title: Remove drupal_add_js() from menu.module » Remove drupal_add_js() from menu.module/remove inline JavaScript from menu.module
Assigned: Unassigned » nod_
Issue tags: +JavaScript
FileSize
1.6 KB

Instead of keeping the exact same behavior here, we might as well improve menu.admin.js so we can get rid of the inline JS function call.

Assigning to nod_, to make sure that inline JS function call didn't exist for some bizarre reason.

nod_’s picture

+ $menu.once('menu-parent', function (a, b, c) {

What are those parameters doing in the anon func signature? other than that, it's ok.

Wim Leers’s picture

#3: d'oh, debug leftovers :/ Thanks for catching that.

nod_’s picture

Status: Needs review » Reviewed & tested by the community

Thanks.

Wim Leers’s picture

Lovely! This is the last remaining drupal_add_js() call :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Awesome work!

Committed and pushed to 8.x. YEAH!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.