Part of #1839338: [meta] Remove drupal_set_*() drupal_add_*() in favour of #attached/response for out-of-band stuff.

CommentFileSizeAuthor
#4 menu_remove_drupal_add_js_and_inline_js-2160593-4.patch1.59 KBwim leers
#2 menu_remove_drupal_add_js_and_inline_js-2160593-2.patch1.6 KBwim leers
#1 2160593-remove_drupal_add_js-menu-1.patch802 bytesvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
StatusFileSize
new 2160593-remove_drupal_add_js-menu-1.patch802 bytes

Initial patch...

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove drupal_add_js() from menu.module » Remove drupal_add_js() from menu.module/remove inline JavaScript from menu.module
Assigned: Unassigned » nod_
Issue tags: +JavaScript
StatusFileSize
new menu_remove_drupal_add_js_and_inline_js-2160593-2.patch1.6 KB

Instead of keeping the exact same behavior here, we might as well improve menu.admin.js so we can get rid of the inline JS function call.

Assigning to nod_, to make sure that inline JS function call didn't exist for some bizarre reason.

nod_’s picture

nod_
Primary language French
Location Lille
commented

+ $menu.once('menu-parent', function (a, b, c) {

What are those parameters doing in the anon func signature? other than that, it's ok.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: nod_ » wim leers
StatusFileSize
new menu_remove_drupal_add_js_and_inline_js-2160593-4.patch1.59 KB

#3: d'oh, debug leftovers :/ Thanks for catching that.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

Thanks.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Lovely! This is the last remaining drupal_add_js() call :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Awesome work!

Committed and pushed to 8.x. YEAH!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.