It affects performance. It is often combined with the Needs profiling tag.
Affects the content, performance, or handling of Javascript.
Part of #1839338: [meta] Remove drupal_set_*() drupal_add_*() in favour of #attached/response for out-of-band stuff.
Initial patch...
Instead of keeping the exact same behavior here, we might as well improve menu.admin.js so we can get rid of the inline JS function call.
menu.admin.js
Assigning to nod_, to make sure that inline JS function call didn't exist for some bizarre reason.
+ $menu.once('menu-parent', function (a, b, c) {
What are those parameters doing in the anon func signature? other than that, it's ok.
#3: d'oh, debug leftovers :/ Thanks for catching that.
Thanks.
Lovely! This is the last remaining drupal_add_js() call :)
drupal_add_js()
Awesome work!
Committed and pushed to 8.x. YEAH!
Automatically closed - issue fixed for 2 weeks with no activity.
Comments
Comment #1
vijaycs85Initial patch...
Comment #2
Wim LeersInstead of keeping the exact same behavior here, we might as well improve
menu.admin.js
so we can get rid of the inline JS function call.Assigning to nod_, to make sure that inline JS function call didn't exist for some bizarre reason.
Comment #3
nod_+ $menu.once('menu-parent', function (a, b, c) {
What are those parameters doing in the anon func signature? other than that, it's ok.
Comment #4
Wim Leers#3: d'oh, debug leftovers :/ Thanks for catching that.
Comment #5
nod_Thanks.
Comment #6
Wim LeersLovely! This is the last remaining
drupal_add_js()
call :)Comment #7
webchickAwesome work!
Committed and pushed to 8.x. YEAH!