Updated: Comment #0
Right now, Edit's JS is being loaded on all pages, as long as the current user has the right permissions. That includes pages like admin or node/1/edit.
At some point we did prevent that from happening, but that changed (and I don't know when or where this was discussed), where we considered the possibility of having a dashboard-like module exposing blocks where you could edit those blocks with in-place editing. Clearly, though, that's an extreme edge case and we shouldn't make 100% of admin page loads slower/heavier because of this oddball use case. It's still possible for a module that wants to support that to load Edit's JS if they want to.
Disable it. Other modules can then still re-enable it using hook_page_build().
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | disable_edit_admin-2160555-1.patch | 569 bytes | wim leers |
Comments
Comment #1
wim leersI discussed this with nod_ and jessebeach (both contributed to Edit module) and they agree Edit should be disabled on admin pages.
Comment #2
wim leersComment #4
wim leers1: disable_edit_admin-2160555-1.patch queued for re-testing.
Comment #6
wim leersI'M STUPID
Comment #7
wim leers1: disable_edit_admin-2160555-1.patch queued for re-testing.
Comment #8
nod_shoudln't that be
if (path_is_admin(current_path()))?Comment #9
wim leers#8:
current_path()is going away; the code being used here is already used elsewhere in core.Comment #10
nod_Comment #11
webchickCommitted and pushed to 8.x. Thanks!
Comment #12
wim leersComment #14
yesct commentedchanging to use the more common tag, so the less common one can be deleted, so it does not show up in the auto complete and confuse people.