Updated: Comment #N

Problem/Motivation

The link display summary and options in the Views UI don't really work as expected at the moment.

- The link display radio buttons have a title of 'Custom URL' - that's just wrong.
- The summary will say none when there is just the master display, and in the form, the only option is 'custom URL'. This is fine until you select this option, then you have no way of turning this off again :)
- When you add a display (and the link_display option is still not set) the summary in the UI will say E.g. 'Page' when this is not true, because nothing is selected.

Proposed resolution

Fix the summary and options form. Also adding a 'None' option to the link display radio options.

Remaining tasks

Fix, test assertions.

User interface changes

Better/working UI for link displays

API changes

None

CommentFileSizeAuthor
Test_view__Content____Site-Install_3.png29.58 KBdamiankloip
Test_view__Content____Site-Install_2.png17.78 KBdamiankloip
Test_view__Content____Site-Install_1.png21.32 KBdamiankloip
vdc.link-display-ui-PASS.patch4.63 KBdamiankloip
vdc.link-display-ui-tests-FAIL.patch1.78 KBdamiankloip

Comments

The last submitted patch, vdc.link-display-ui-tests-FAIL.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Title: Link display form and summary needs fixing » [regression] Link display form and summary needs fixing
Status: Needs review » Reviewed & tested by the community

These are the things which don't cause major issues though will annoy people

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.