drupal_load() is called pointlessly

doesnt make sense indeed

Hi! I've checked all remaining places where drupal_load() is called and looks like there is no sense in calling it. So I've decided to remove it all remaining places of the drupal_load() usage.

One more try...

So it seems that not all drupal_loads was pointless even Drupal installation succeeded without them. I've tested locally different variations of Drupal installation and everything was ok, but testbot fails without these drupal_loads. Here is patch which removes calls mentioned in #2 and changes remaining ones to ModuleHandler::load().

6: drupal-core-remove-drupal_load-using-2159911-6.patch queued for re-testing.

1. +++ b/core/modules/forum/forum.install
   @@ -104,15 +104,12 @@ function forum_module_preinstall($module) {
      // Load the dependent Comment module, in case it has been disabled.
   -  drupal_load('module', 'comment');
   +  \Drupal::moduleHandler()->load('comment');
   

   Comment module cannot be uninstalled prior to Forum module, because Forum module depends on Comment module, so this load is obsolete.

   (the code comment is obsolete too, since modules also cannot be disabled anymore)

2. +++ b/core/modules/system/lib/Drupal/system/Tests/File/ScanDirectoryTest.php
   @@ -61,7 +61,7 @@ function testReturn() {
      function testOptionCallback() {
   -    drupal_load('module', 'file_test');
   +    \Drupal::moduleHandler()->load('file_test');
   

   This one should be completely obsolete, since the test defines/enables 'file_test' module via $modules already.

@sun, thanks for the review! But actually I've tried this in my first patch and it failed tests. Here I've created a re-roll for it, cause it is not applicable yet, let's see what testbot says.