This is used to aggregate EntityResolvers and iterate over them. Let's unit test this class.

CommentFileSizeAuthor
#2 interdiff-2159755-2.txt918 bytesdamiankloip
#2 2159755-2.patch5.36 KBdamiankloip
D8.ChainEntityResolverTest.patch5.31 KBdamiankloip

Comments

dawehner’s picture

dawehner
Primary language German
commented 
  1. +++ b/core/modules/serialization/tests/Drupal/serialization/Tests/EntityResolver/ChainEntityResolverTest.php
@@ -0,0 +1,130 @@
+ * @group Serialization

    @group Drupal would be cool. 

  2. +++ b/core/modules/serialization/tests/Drupal/serialization/Tests/EntityResolver/ChainEntityResolverTest.php
@@ -0,0 +1,130 @@
+

    {@inheritdoc} :( 

  3. +++ b/core/modules/serialization/tests/Drupal/serialization/Tests/EntityResolver/ChainEntityResolverTest.php
@@ -0,0 +1,130 @@
+  protected function createEntityResolverMock($return = NULL, $called = TRUE) {

    This is quite a cool trick to save typing!

damiankloip’s picture

damiankloip commented
StatusFileSize
new 2159755-2.patch5.36 KB
new interdiff-2159755-2.txt918 bytes

Nice, thank you!

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you!

xjm’s picture

xjm
she/her
Primary language English
commented

2: 2159755-2.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.