Unit test the Drupal\serialization\Normalizer\NormalizerBase class [#2159737]

The abstract Drupal\serialization\Normalizer\NormalizerBase class only contains a supportsNormalization() method. This is a simple method with simple logic, but nonetheless, it should be unit tested. Especially as pretty much all normalizers rely on this logic in some way.

Comment	File	Size	Author
#2	interdiff-2159737-2.txt	3.44 KB	damiankloip
#2	2159737-2.patch	4.18 KB	damiankloip
	D8.NormalizerBaseTest.patch	3.73 KB	damiankloip

Comments

Comment #1

dawehner

German

commented 21 December 2013 at 13:54

+++ b/core/modules/serialization/tests/Drupal/serialization/Tests/Normalizer/NormalizerBaseTest.php
@@ -0,0 +1,76 @@
+
...
+ *
+ * @group Serialization

Same as before :(

+++ b/core/modules/serialization/tests/Drupal/serialization/Tests/Normalizer/NormalizerBaseTest.php
@@ -0,0 +1,76 @@
+    $this->assertFalse($normalizer_base->supportsNormalization(new \stdClass()));
...
+  public function testSupportsNormalization() {

What about using a dataProvider here?

+++ b/core/modules/serialization/tests/Drupal/serialization/Tests/Normalizer/NormalizerBaseTest.php
@@ -0,0 +1,76 @@
+abstract class TestNormalizerBase extends NormalizerBase {

Can't we just use a non abstract test class and use a proper new in the test?

Comment #2

damiankloip commented 21 December 2013 at 14:17

Status	File	Size
new	2159737-2.patch	4.18 KB
new	interdiff-2159737-2.txt	3.44 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	D8.NormalizerBaseTest.patch	3.73 KB

Thanks once again! Converted to data provider.

As discussed, I don't think it's better to not have an abstract class, as we then have to stub the normalize() method ourselves too. Let's use some of these cool PHPUnit features :)