Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.In several places Drupal.dialog is called with either a string or a jQuery object, it should be a DOM element, see #2158943: Add a native dialog element to deprecate the jQuery UI dialog why this is important.
And soon we will want to actually use the <dialog> tag instead of divs.
| Comment | File | Size | Author |
|---|---|---|---|
| core-js-dialog-DOM-element.patch | 2.86 KB | nod_ |
Comments
Comment #1
wim leersManually tested. Still works perfectly. Verified that zero incorrect remaining calls exist. Only JS is changed, so unless testbot trips over itself, this will come back green. Hence: RTBC.
Comment #2
xjmcore-js-dialog-DOM-element.patch queued for re-testing.
Comment #3
xjmcore-js-dialog-DOM-element.patch queued for re-testing.
Comment #4
catchCommitted/pushed to 8.x, thanks!