Small and simple, noticed whilst reviewing #2156835: ConfigStorageController is not using entity query for loadByProperties. The ConfigEntityUnitTest::testStorageControllerMethods() test only checks the first entity that is loaded by property with the 'style' key. This should really check that both of the returned entities have that matching key. Simple really.

CommentFileSizeAuthor
D8.entity-property-test-assertion.patch969 bytesdamiankloip

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +PHPUnit

+1

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.