ConfigStorageController has 6 methods that are not on any interface. This should be rectified.

CommentFileSizeAuthor
#2 config-2157871-2.patch16.49 KBtim.plunkett
config-storage-interface.patch11.86 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +Quick fix
StatusFileSize
new config-2157871-2.patch16.49 KB

Reroll

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Nice find. It is RTBC until bot thinks otherwise.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: -Quick fix

That is really stretching the term "Quick fix." ;) I'll try and look at this later when I'm done with the easy ones.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ff0fdc4 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.