Problem/Motivation

Currently EntityDefaultViewsController creates automatically the necessary views data to integrate an entity type into views. Unfortunately this doesn't cover the revisions of the entity type.
But I think we've enough information to do that automatically as well.

Proposed resolution

The attached patch bases on the code found in the node revision integration of views

Remaining tasks

Reviews needed.

User interface changes

None

API changes

New method EntityDefaultViewsController::schema_revision_fields().

CommentFileSizeAuthor
#2 entity-views-integration-revision-support-2157331-2.patch3.31 KBdas-peter
#2 interdiff-2157331-0-2-do-not-test.diff510 bytesdas-peter
entity-views-integration-revision-support.patch3.31 KBdas-peter

Comments

matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

This seems to work fine, but I do have one minor remark: I think it would be better to use $revision_table instead of "node_revision" as relationship name (line 13 in the patch). This is probably copy/paste related ;-)

das-peter’s picture

das-peter commented
StatusFileSize
new interdiff-2157331-0-2-do-not-test.diff510 bytes
new entity-views-integration-revision-support-2157331-2.patch3.31 KB

@Matthijs Thanks for testing!

Fixed copy pasta leftover.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

This looks great - thanks! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.