merge ConfigEntityReferenceItemBase up into EntityReferenceItem, and fix inconsistencies

If nothing breaks, I'm super excited for this patch :)

(Except for that whitespace you have in the interdiff :P)

I don't really plan on pushing this myself for now

lol :)

+++ b/core/lib/Drupal/Core/Field/Plugin/Field/FieldType/EntityReferenceItem.php
@@ -149,4 +149,30 @@ public function getMainPropertyName() {
+    if (empty($this->target_id) && ($entity = $this->entity) && $entity->isNew()) {

Shouldn't this do the same $target_id === NULL check like isEmpty()?

Yay, thanks!

Oops..

#597236: Add entity caching to core also has a fix for ConfigEntityReferenceItemBase, looks like this is better and the other fix can be removed after this..

More green :p

Nice cleanup.

21: remove_ConfigEntityReferenceItemBase-2156337-21.patch queued for re-testing.

Rerolled, also I just found image_entity_presave(EntityInterface $entity, $type) has an extra param $type.

As stated in issue summary, this deleted "ConfigEntityReferenceItemBase" is only for "entity autocreate". While this patch passed, I feel the functions, i.e, presave() and isEmpty(), shouldn't be used for fileitem and imageitem, which two items are not meant for autocreate. It may confuse people a bit -- could it be possible to "autocreate" a file or image with some autowidget ?:)

Also, it's not related much, but can we move image_entity_presave(EntityInterface $entity) to imageitem:presave()?

Auto-creating an entity should be possible for all entity types and entity reference-like fields, which includes file and image, so I don't see why we shouldn't allow them to do that.

Edit: Yeah, @yched said it better :)

Yeah, sorry, that function is working on the entity~ Also, it sounds logic to add the support here for contrib code to make use of this auto-create feature.

That getValue function introduces an $value['entity'] = $this->entity. It breaks image field. Image field produces its entity in its own way(I don't know where it is yet^). Removing that works fine for image field, lets see if it breaks other fields.

You can't delete that, that is necessary.

38: remove_ConfigEntityReferenceItemBase-2156337-38.patch queued for re-testing.

Weird unserialize errors (unserialize(): Error at offset 867267 of 1187046 bytes), re-testing.

Apparently not random then.

The two tests failed in my computer. I'm using php 5.4.13.

I just manually created a view with fields "action_bulk_form:" and "node_bulk_form:" , and the views page looks fine.

I just fond one intersting thing about the test views.
views.view.test_bulk_form.yml
contains :

          plugin_id: action_bulk_form
          provider: action

The views I just created has this:

          plugin_id: action_bulk_form
          provider: views

This fixes it for me.

I guess we should really consider moving entity_reference to Core instead of a module..

amateescu++

PHP 5.5.3 segfaults for me when running these tests without that dependency in zend_hash_find, within serialization stuff. No idea why.

@yched, no idea.. I just tried by instinct and it worked.

I looked more into it for about 6-7 hours this evening and it seems there's some weird issue with the list classes.

Basically, the interdiff in #48 fixes the failures because it replaces the list class from Drupal\Core\Field\FieldItemList to Drupal\entity_reference\Plugin\Field\FieldType\ConfigurableEntityReferenceFieldItemList. The funny thing is that even Drupal\Core\Field\ConfigFieldItemList works as a replacement, the "fix" is not tied to the configurable e_r list class, but to the fact that ConfigFieldItemList implements ConfigFieldItemListInterface...

This led me to Drupal\Core\Entity\FieldableEntityStorageControllerBase, and apparently the issue comes from iterating on entity fields in loadFieldItems(). If you apply the attached interdiff to the patch from #38, those two tests will pass. I've no effin` clue what might go wrong in there, so I hope either one of you will be able to crack it.

And a small shameless plug.. while investigating this stuff, I also found 3 unrelated bugs:
#2171753: entity_reference_field_info_alter() overrides 'list_class' twice
#2171757: Drupal\views\Form\ViewsForm should extend DependencySerialization
#2171759: Drupal\Core\Field\ConfigFieldItemList tries to use an inexistent FieldInstanceInterface

Phew, that was fun! (not) :) Fixed some small doc issues and this is RTBC.

I think you meant this :)

I just noticed that the reroll from #61 removed AllowedValuesInterface from the list of interfaces implemented by ConfigurableEntityReferenceItem. It's a minor fix so leaving at RTBC.

66: remove_ConfigEntityReferenceItemBase-2156337-66.patch queued for re-testing.

Bot acting crazy..

Committed f5ba64c and pushed to 8.x. Thanks!