Drupal/edit/EditController, Drupal/edit/Access/EditEntityFieldAccessCheck still rely on field_valid_language().
That function is now totally obsolete, and all the "old Field multilingual API" needs to be removed in #2067079: Remove the Field Language API.

The logic in edit.module should move to the new Entity API logic - probably $entity->hasTranslation() ?

CommentFileSizeAuthor
#3 edit_field_valid_language-2155665-3.patch3.96 KBwim leers

Comments

yched’s picture

yched commented
Issue tags: +beta target, +EntityField API

beta target, since this is blocking #2067079: Remove the Field Language API

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Update field_valid_language() calls in Edit.module » Update field_valid_language() calls in edit.module
Assigned: Unassigned » wim leers
Issue tags: +Spark, +sprint

On it.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
Related issues: +#2067079: Remove the Field Language API
StatusFileSize
new edit_field_valid_language-2155665-3.patch3.96 KB

Et voilà.

Very happy to be able to delete that ugly hack in EditEntityFieldAccessCheckTest :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Parent issue: » #2067079: Remove the Field Language API
Related issues: -#2067079: Remove the Field Language API
yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community

Délicieux :-) Merci @Wim !

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +D8MI, +language-content

Yay, thanks, looks good for me too :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: -sprint

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.