This is not a joke :)

Taking EntityFieldTest as an example, which apparently generates 38 passwords, takes more than 3 seconds in that function, other tests might not be as much but still a few.

The upcoming patch sets the log count variable for DUBT tests to 1, which results in the password hash generation taking 14msec instead.

CommentFileSizeAuthor
#1 password-log-count-2154961-1.patch811 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review
FileSize
password-log-count-2154961-1.patch811 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs review » Reviewed & tested by the community

Can not see any disadvantages to doing this! Nice find :)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

1: password-log-count-2154961-1.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

Why not do this for web tests too?

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Thought about it but we currently don't have the possibility to do that.

I know there's an issue to add a testing service provider in an issue, but I can't remember which one right now, that would help.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Fair enough. Committed/pushed to 8.x, thanks!

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

It roughly looks like inside DrupalKernel::initializeContainer() you could make some tweaks if the environment is "testing"?

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

opened a new issue: #2165549: Reduce number of password hashing iterations in all tests to improve test performance

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.