in og_entity_update() we should try to map the roles according to their name.

Work is on branch 2153555

CommentFileSizeAuthor
#8 interdiff.txt1.83 KBamitaibu
#8 2153555-og-role-maintain-on-revert-8.patch3.72 KBamitaibu
#6 innerdiff.diff867 bytesNofarG
#6 2153555-og-role-maintain-on-revert-6.patch1.89 KBNofarG
#3 2153555-og-role-maintain-on-revert-2.patch1.94 KBamitaibu
#1 2153555-og-role-maintain-on-revert-1.patch1.97 KBamitaibu

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Active » Needs review
StatusFileSize
new 2153555-og-role-maintain-on-revert-1.patch1.97 KB

Still needs simpleTest

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Issue summary: View changes
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
StatusFileSize
new 2153555-og-role-maintain-on-revert-2.patch1.94 KB

Feature should be on by default.

The last submitted patch, 1: 2153555-og-role-maintain-on-revert-1.patch, failed testing.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

@Nofar tests should be added in OgDefaultAccessFieldTestCase::testOgDefaultAccessField. Test should cover the case when variable is TRUE and FALSE.

NofarG’s picture

NofarG commented
StatusFileSize
new 2153555-og-role-maintain-on-revert-6.patch1.89 KB
new innerdiff.diff867 bytes

The "continue;" makes it skip the og_role_delete() .
Here's a new patch.

Status: Needs review » Needs work

The last submitted patch, 6: innerdiff.diff, failed testing.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs work » Needs review
StatusFileSize
new 2153555-og-role-maintain-on-revert-8.patch3.72 KB
new interdiff.txt1.83 KB

Patch adds tests.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.