If a site is busy at the time the garbage collector kicks in, it is possible for the system to have a meltdown if nothing finishes the garbage collect fast enough.

CommentFileSizeAuthor
#1 cache_meltdown_HEAD.patch1 KBbdragon
cache_meltdown.patch1023 bytesbdragon

Comments

bdragon’s picture

bdragon commented
StatusFileSize
new cache_meltdown_HEAD.patch1 KB

Same for HEAD.

gerhard killesreiter’s picture

gerhard killesreiter commented
Status: Needs review » Reviewed & tested by the community

1 line change, good to go, already live on drupal.org.

gerhard killesreiter’s picture

gerhard killesreiter commented
Version: 5.x-dev » 6.x-dev

This should go into D6 first.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 6.x-dev » 5.x-dev

Great, committed to 6.x. RTBC for 5.x.

hass’s picture

hass commented

Are you really sure this makes sense?

If a cache is not flushed successfully - the variable shouldn't tell it is flushed successfully. This change sounds very illogical and keeps stale data.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Hass, the variable_set() never checked the success of the query, so there is no such change as you explained.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

Committed to 5.x.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

etamar’s picture

etamar commented
Priority: Critical » Normal
Status: Closed (fixed) » Active

Hi guys,

I think the "well rounded" / "good" behavior would be adding a global variable to determine "being flushed", and not use the "flushed" variable as it is confusing and erratic as hass correctly mentioned.

This is from a good practices point of view,

To your review,
Etamar

mot’s picture

mot commented

etamar, doesn't work the fix for you?

mot’s picture

mot commented
Status: Active » Closed (fixed)

No answer, so a positive is assumed. Closed again.