My first @dataProvider test :) Easily halves the size of the test class.

CommentFileSizeAuthor
#11 2152355_6.patch3.92 KBchx
#11 interdiff.txt668 byteschx
#10 2152355_5.patch3.63 KBchx
#8 2152355_3.patch3.62 KBchx
#3 2152355_3.patch3.62 KBchx
#3 interdiff.txt1.02 KBchx
ed_provider.patch3.48 KBchx

Comments

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/migrate/tests/Drupal/migrate/Tests/process/DedupeEntityTest.php
@@ -44,65 +44,38 @@ public function setUp() {
   /**
...
+   * @dataProvider provider
...
+  public function test($count, $postfix = '') {

Let's use testDedupe and providerTestDedupe as well as provide some basic documentation for the two methods.

chx’s picture

chx commented
Status: Active » Needs review
chx’s picture

chx commented
StatusFileSize
new interdiff.txt1.02 KB
new 2152355_3.patch3.62 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2152355_3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review

3: 2152355_3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2152355_3.patch, failed testing.

The last submitted patch, 3: 2152355_3.patch, failed testing.

chx’s picture

chx commented
Status: Needs work » Needs review
StatusFileSize
new 2152355_3.patch3.62 KB

Status: Needs review » Needs work

The last submitted patch, 8: 2152355_3.patch, failed testing.

chx’s picture

chx commented
Status: Needs work » Needs review
StatusFileSize
new 2152355_5.patch3.63 KB

The phpunit error reporting could use some love.

chx’s picture

chx commented
StatusFileSize
new interdiff.txt668 bytes
new 2152355_6.patch3.92 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

This looks fine!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice clean-up!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.