Problem/Motivation

Toolbar in vertical state has orientation toggle on light gray background witch then switches back to white background below it.
This does not look good and does not separate menu from toolbar tray the way it could.

Proposed resolution

Making toolbar background also light gray creates visual distinction from menu items and simplifies it.

Remaining tasks

User interface changes

Change toolbar background to light gray - same as toolbar orientation toggle background color.

API changes

None.

Cleaner toolbar background in vertical state

CommentFileSizeAuthor
#6 vertical-menu-cleaner.png15.74 KBroyal121
#3 vertical-toolbar-cleaner-background-2151265-3.patch696 bytesphilipz
#2 vertical-toolbar-cleaner-background-2151265-2.patch721 bytesphilipz
vertical-toolbar-cleaner-background.patch696 bytesphilipz
vertical-toolbar-cleaner-background.jpg146.08 KBphilipz

Comments

Status: Needs review » Needs work

The last submitted patch, vertical-toolbar-cleaner-background.patch, failed testing.

philipz’s picture

philipz commented
Status: Needs work » Needs review
StatusFileSize
new vertical-toolbar-cleaner-background-2151265-2.patch721 bytes
philipz’s picture

philipz commented
StatusFileSize
new vertical-toolbar-cleaner-background-2151265-3.patch696 bytes

Patch re-roll after #2100133: The Toolbar tray box shadow disappears at small viewports sizes on Chrome, on a Mac, under unpredictable conditions

philipz’s picture

philipz commented
Title: Toolbar background cleaner in vertical state » Make Toolbar background cleaner in vertical state
Assigned: philipz » Unassigned

Title changed.

philipz’s picture

philipz commented
Issue tags: +CSS
royal121’s picture

royal121 commented
StatusFileSize
new vertical-menu-cleaner.png15.74 KB

I tested the patch in comment #3 and it worked great! Here is the screenshot:

After and Before patch

In my opinion this is a nice change.

philipz’s picture

philipz commented
Category: Feature request » Task

Making it a task not a feature request since this is not a feature. Thanks for trying the patch!

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Reviewed & tested by the community

This looks a lot better, I played around I couldn't find any other regressions.

xjm’s picture

xjm
she/her
Primary language English
commented

3: vertical-toolbar-cleaner-background-2151265-3.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Looks nice. :)

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.