When doing a simple config import, say 'system.site', the confirm form will ask you if it wants to create a new one, even though system.site clearly exists.
It should ask for 'update' instead.

CommentFileSizeAuthor
#3 2150171.3.patch2.24 KBalexpott
#3 2150171.3.test-only.FAIL_.patch1.55 KBalexpott
#1 2150171-1.patch797 bytesswentel

Comments

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 2150171-1.patch797 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +Needs tests

Have not confirmed the bug but we obviously need tests :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2150171.3.test-only.FAIL_.patch1.55 KB
new 2150171.3.patch2.24 KB

Confirmed the issue - added tests and fixed in a slightly different way as the fix in #1 since that fix did not meet the expectation laid out by the docs in the class.

  /**
   * If the config exists, this is that object. Otherwise, FALSE.
   *
   * @var \Drupal\Core\Config\Config|\Drupal\Core\Config\Entity\ConfigEntityInterface|bool
   */
  protected $configExists = FALSE;

The last submitted patch, 3: 2150171.3.test-only.FAIL_.patch, failed testing.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Right, much better fix, duh :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Awesome, thanks. I caught this today too in my testing.

Committed and pushed to 8.x. Thanks!

swentel’s picture

swentel commented
Status: Fixed » Reviewed & tested by the community

I think you forgot to push this one

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Oh, what, is that important or something? ;)

Sorry. Pushed this time.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.