The minor bugs:

  • There's a bizarre bug in jQuery where calling `.removeAttr('contentEditable')` fails and calling `.removeAttr('contenteditable')` works. So changed to the latter.
    See http://bugs.jquery.com/ticket/7792.
    
  • core/modules/edit/js/util.js is listed *after* edit.js; in rare situations it's possible that code in util.js is called before it has loaded, changing the order fixes that
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
10.84 KB

As said in the issue title: this patch is brought to you by the D7 backport of Edit module :)

jessebeach’s picture

I did manual regression testing for this change. I did not find any regressions related to this issue, but I did find a bug:

#2153191: Removing an image from an article with quick edit does not trigger a field content change; the image is not removed.

Again, unrelated as far as I can tell from this refactor that just changes some comments and variable names.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Wim Leers’s picture

Issue tags: -sprint
nod_’s picture

Issue tags: +JavaScript

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.