Follow-up from #1945406: [meta] Convert all of confirm_form() to ConfirmFormBase.

There are two blockers for this left.

CommentFileSizeAuthor
confirm_form.patch3.59 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: Unassigned » tim.plunkett
Priority: Normal » Major

So I don't lose it.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Parent issue: » #1945406: [meta] Convert all of confirm_form() to ConfirmFormBase
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Postponed » Needs review
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community

Yes, let's do this. Since this is not just a dumb wrapper like t() or whatever keeping this means we need to support it and we really don't want to do that.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Major » Normal

Sorry, this is not major.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Remove confirm_form() » Change notice: Remove confirm_form()
Priority: Normal » Major
Status: Reviewed & tested by the community » Active
Issue tags: +Approved API change, +Needs change record

Ok. I can't seem to envision a way to make this just a dumb wrapper function, so despite this being an API change, it should probably go in. confirm_form() has been marked deprecated for quite awhile, so hopefully this won't impact too many contribs. Adding the tag.

Committed and pushed to 8.x. Thanks!

Looks like we need to update https://drupal.org/node/1945416 accordingly, now.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: tim.plunkett » Unassigned
chakrapani’s picture

chakrapani commented
Assigned: Unassigned » chakrapani

working on the change record.

chakrapani’s picture

chakrapani commented

The change record https://drupal.org/node/1945416 has been updated with the following changes:

  • Changed title from confirm_form() deprecated to removed.
  • Mentioned explicitly in the description that confirm_form() has been removed.
  • Added https://drupal.org/node/2149263 as one of the related issues.
  • Changed D8 example code making the methods as public.
chakrapani’s picture

chakrapani commented
Title: Change notice: Remove confirm_form() » Remove confirm_form()
Status: Active » Fixed
Issue tags: -Needs change record

Marking as fixed.

chakrapani’s picture

chakrapani commented
Priority: Major » Normal

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.