Replace format_interval with \Drupal::service('date')->formatInterval()

The attached patch injects the date service when possible, and uses \Drupal::service('date')->formatInterval() in procedural code.

Fixed one typo.
I don't have any idea about the views fields related failures, I will try to ping someone for those.

Just found that it was the very same typo in a different place.

Nice catches!

+++ b/core/includes/batch.inc
@@ -298,9 +298,10 @@ function _batch_process() {
+      '@estimate'   => ($current > 0) ?
+              \Drupal::service('date')->formatInterval(($elapsed * ($total - $current) / $current) / 1000) : '-',

@@ -389,7 +390,8 @@ function _batch_finished() {
+            \Drupal::service('date')->formatInterval($batch_set['elapsed'] / 1000));

+++ b/core/modules/aggregator/aggregator.pages.inc
@@ -75,7 +75,8 @@ function template_preprocess_aggregator_item(&$variables) {
+    $variables['source_date'] = t('%ago ago',
+        array('%ago' => \Drupal::service('date')->formatInterval(REQUEST_TIME - $item->getPostedTime())));

@@ -168,7 +169,8 @@ function template_preprocess_aggregator_summary_item(&$variables) {
+    '#text' => t('%age old', array('%age' =>
+        \Drupal::service('date')->formatInterval(REQUEST_TIME - $item->getPostedTime()))),

@@ -208,7 +210,8 @@ function template_preprocess_aggregator_feed_source(&$variables) {
+    $variables['last_checked'] = t('@time ago',
+        array('@time' => \Drupal::service('date')->formatInterval(REQUEST_TIME - $feed->checked->value)));

These indentations (and others throughout) are non-standard. Either split onto two lines, or leave s one (which is fine!)

Oops, I thought that I was improving the situation instead of going backwards... Sorry.
Attended Tim feedback-

We are supposed to use $this->container->get() inside simpletests instead of \Drupal (just lernt that in #2149195-18: Replace format_plural with \Drupal::translation()->formatPlural())

Straight reroll.

Just unlernt #14 because it is under discussion (see #2087751: [policy, no patch] Stop using $this->container in web tests).

15: 2149197-formatInterval-15.patch queued for re-testing.

repeating history (rerolled #22).

and that.

How is that WSCCI? WSCCI !== Make stuff services.

Rerolled after #2005716: Promote EntityType to a domain object landed.

Tests failed because couldn't write config files.

27: 2149197-format_interval-27-with-system_install.patch queued for re-testing.

Rerolled.

Forgot a comma while merging.

35: 2149197-format_interval-35-with-system_install.patch queued for re-testing.

Tried to apply and re-roll the last patch without success, so here's a manual re-roll and update. Should this patch also remove the original format_interval function?

Whoops empty patch. Also my first version I tried to add ContainerFactoryPluginInterface to BlockBase in order to inject the date service, but that broke a number of other block plugins, what's the best way to go about resolving that?

Missing an assignment in a constructor.

And now with format_interval removed as well.

1. +++ b/core/modules/aggregator/src/Controller/AggregatorController.php
   @@ -19,6 +21,32 @@
   +   * @var \Drupal\Core\Datetime\Date
   ...
   +   * @param \Drupal\Core\Datetime\Date $date_service
   ...
   +  public function __construct(DateService $date_service) {
   

   Urgs, this is quite confusing, but I guess Date is already part of the global namespace, right?

2. +++ b/core/modules/aggregator/src/Controller/AggregatorController.php
   @@ -19,6 +21,32 @@
   +  protected $dateService;
   

   I wonder whether we can come up with a more descriptive name for the variable? Maybe just dateFormatter in cases it makes sense ?

Renamed to dateFormatter and cleaned up usage around core as well.

Typo in that last file I had open...

Found another missing rename.

Should we add formatInterval method on controller, plugin, form etc as was done with formatPlural over at #2149195: Replace format_plural with \Drupal::translation()->formatPlural()

Thank you for that hard work!

Reading this issue makes me want to ask for the date to be renamed date.formatter and the class to be renamed too.

Committed 5783e08 and pushed to 8.x. Thanks!

Opened a followup at #2309221: Drupal\Core\Datetime\Date should be renamed to DateFormatter