Closed (fixed)
Project:
Panopoly
Version:
7.x-1.x-dev
Component:
Tests / Continuous Integration
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Dec 2013 at 19:24 UTC
Updated:
16 Feb 2015 at 20:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
lsolesen commentedDiscovered problems when writing the test. It does not seem possible to save the checkboxes with a different value after they have been saved once.
However, I cannot get into Settings using Behat to get the test correct.
Comment #2
dsnopekThanks! It's really great all the bugs you are finding. :-) I got this one to run using the same technique as in #2149175: Write Behat tests for Panopoly "content list" widget, however, it's still failing because of the bug.
I'm going to hold off on committing this until we have a fix for the bug, which I've made a seperate issue for #2153277: Can't change checkboxes in "Submenu" widget after it's been created.
Comment #3
lsolesen commentedPatch in #2 do not apply anymore. Rerolled against latest dev.
Comment #4
lsolesen commentedThe test is actually not correct, as it would not be expected to have any submenu shown in the given circumstances. That is a case of #2177417: Widget output when editing with IPE can be different than when viewing the page normally (easily reproducable with "Submenu" widget)
Comment #5
lsolesen commentedPlease see most recent work in the submenu branch on github.
Comment #6
dsnopekComment #7
dsnopekFor future reference, here is the 'submenu' branch on @lsolesen's github:
https://github.com/lsolesen/panopoly/tree/submenu
Comment #8
dsnopekHere is the most recent version of this patch, extracted from @lsolesen's branch on GitHub. This will need to be updated to the new way that we do our tests, ie:
If anyone wants to take this on, just take a look at the other widget tests and mimick what they're doing.
Comment #9
dsnopekHere is a new patch that is re-rolled against panopoly_test and only slightly updated for the new way of doing things. It still needs the to be updated to not be dependent on the demo data - it should create any panopoly_test_page nodes that it needs to complete the tests.
Comment #10
dsnopekHere is a patch that actually passes! I had to remove the test that exposes #2177417: Widget output when editing with IPE can be different than when viewing the page normally (easily reproducable with "Submenu" widget) because we don't yet have a solution to that problem. But you can look at earlier patches to see what it did. I'll commit this momentarily!
Comment #12
dsnopekCommitted!