Part of #2128157: [meta] Implement continuous integration for Panopoly.

CommentFileSizeAuthor
#8 panopoly-add_test_image_widgit-2149157.patch1.62 KBbwood
#2 add-test-image-widget.patch1.45 KBlsolesen

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Parent issue: » #2128157: [meta] Implement continuous integration for Panopoly
lsolesen’s picture

lsolesen commented
Status: Active » Needs review
StatusFileSize
new add-test-image-widget.patch1.45 KB

Maybe there should be a test here also for whether the image is actually shown on the page.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Yeah, it'd be great to be able to say:

Then I should see an image with the alternate text "blah"

But then we'll need to also upload the image and get the "Alternate text" field.

lsolesen’s picture

lsolesen commented

In wetkit the accessibility test has a check for alt text

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Ah, sweet! I found the code here:

http://drupalcode.org/project/wetkit.git/blob/refs/heads/7.x-1.x:/tests/...

Can you add this to your patch and use it for the image test?

lsolesen’s picture

lsolesen commented

Checkout https://travis-ci.org/lsolesen/panopoly/builds/14969671 --> For some reason I could not get it to work correctly. And I have no more time to dig into it for now. It is probably a simple spelling mistake somewhere?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Component: Code » Tests / Continuous Integration
bwood’s picture

bwood commented
StatusFileSize
new panopoly-add_test_image_widgit-2149157.patch1.62 KB

Here's a patch that adds the alt text test.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Worked for me, so I've committed! Thanks @lsolesen and @bwood!

@bwood: You now have you're first commit listed on your Drupal.org profile page. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.