Uploading Files produces JS error

Getting the same issue.

I'm seeing this too - looks like Clientside Validation is trying to use the accept method, but:

1. Accept is now mimetype based - the filename based version has been renamed to extension
2. Both were moved to the additional-methods.js file, which we don't currently have.

Please try the dev release.
I believe this issue has been fixed by #2056219: General problem with drupal AJAX requests prevented by clientside validation.
If it still happens, please reopen this issue.

This isn't Clientside Validation preventing the AJAX request, this is a javascript error because of a change in the jquery-validation library.

I fixed it on our client's site with the attached patch... it could be a bit more sophisticated about when to load the additional methods, mind.

@grahamC there have been changes since 1.38
Did you try with the latest dev? Can you provide steps to reproduce the error?

OK, so trying with latest HEAD upload works fine, as does file extension validation. Yay!...

...But there's still an error output to the JS console, Uncaught TypeError: Cannot call method 'call' of undefined, on line 542 of jquery.validate.js, namely result = $.validator.methods[method].call( this, val, element, rule.parameters ); which is the same issue that my patch was aimed at.

I don't have a clue how the validation is working in spite of this error : )

(to reproduce: I just enabled clientside_validation_webform, created a new Webform, added a File component, enabled validation for that form using the default settings)

Great. Is that 40k patch required to fix that JS error? Does it still apply?

@grahamC: with latest HEAD the upload works because the broken validation has been disabled by default (see #2056219: General problem with drupal AJAX requests prevented by clientside validation). It hasn't been fixed though.

@barraponto: Yes. clientside validation bundles jquery.validation.js (which is deprecated) and was missing a file. Adding that file makes the patch so large.

I've found another issue with this patch: If JS aggregation is enabled we need weights in drupal_add_js() to guarantee that additional_methods.js is loaded after jquery.validation.js.

Here is an updated patch.

Digging to see why validation still appears to work, I discovered that Drupal has built-in client-side validation for file widgets (Drupal.file.validateExtension).

So I vote for ripping out extension validation from clientside_validation_webform ... and to the casual observer that seems to be the only place that was using it in the first place?!

I had a look at this, but I think it's better to not use the one big additional file, but instead only include the ones we need.

I removed the code in _clientside_validation_set_extensions for the moment so it no longer breaks

file extension validation is disabled, I opened #2184745: Decide how to add the additional validation methods to decide on how to add the additional methods