The Panelizer vertical tab on entity settings forms should really provide a summary of the current settings, similar to how other modules do, e.g. Comments, Metatag, etc.

CommentFileSizeAuthor
#2 panelizer-n2147759-2.patch2.69 KBdamienmckenna

Comments

damienmckenna’s picture

Category: Feature request » Bug report

The module already has some code for this, but the DOM structure changed and it no longer applies. So this is a bug report instead of a feature request.

damienmckenna’s picture

Category: Bug report » Feature request
Status: Active » Needs review
StatusFileSize
new2.69 KB

Actually the existing code is for the entity object edit form, e.g. node edit, not the entity bundle edit form.

This adds the necessary JS and tweaks the form's DOM slightly to make the JS less insane.

damienmckenna’s picture

Some code to help identify whether the 'Provide default panel' and 'Allow panel choice' options are selected:

        var name = $(this).attr('name').replace(/panelizer\[view modes\]\[(.*)\]\[status\]/, "$1");
        alert(name);
        alert($('input[name*="view modes"][name*=' + name + '][name*=default]:checked', context).length);
        alert($('input[name*="view modes"][name*=' + name + '][name*=choice]:checked', context).length);
damienmckenna’s picture

Lets see if I can kick the automated tests into gear.

damienmckenna’s picture

Status: Needs review » Needs work
damienmckenna’s picture

Status: Needs work » Needs review
damienmckenna’s picture

Status: Needs review » Fixed

I tested it out on a plain sandbox in addition to a fully loaded site, it worked fine in both so I committed it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.