Top cart of a stock Drupal Commerce doesn't work with this module

It is a clean install ? Do you have an url to check?

For confirmation message please check
https://drupal.org/project/commerce_add_to_cart_confirmation

Works out of the box with this module.

Please give me a hint. What is vanilla drupal ?

This would be an idea. Make an submodule to cover this issue.

I can confirm that importing the following view into a Vanilla Commerce installation works.

$view = new view();
$view->name = 'shopping_cart';
$view->description = '';
$view->tag = 'default';
$view->base_table = 'commerce_order';
$view->human_name = 'shopping cart';
$view->core = 7;
$view->api_version = '3.0';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Master */
$handler = $view->new_display('default', 'Master', 'default');
$handler->display->display_options['title'] = 'shopping cart';
$handler->display->display_options['use_more_always'] = FALSE;
$handler->display->display_options['access']['type'] = 'none';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['query']['options']['query_comment'] = FALSE;
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['pager']['type'] = 'none';
$handler->display->display_options['pager']['options']['offset'] = '0';
$handler->display->display_options['style_plugin'] = 'default';
$handler->display->display_options['row_plugin'] = 'fields';
/* Footer: Commerce Line Item: Line item summary */
$handler->display->display_options['footer']['line_item_summary']['id'] = 'line_item_summary';
$handler->display->display_options['footer']['line_item_summary']['table'] = 'commerce_line_item';
$handler->display->display_options['footer']['line_item_summary']['field'] = 'line_item_summary';
$handler->display->display_options['footer']['line_item_summary']['links'] = array(
  'view_cart' => 0,
  'checkout' => 'checkout',
);
$handler->display->display_options['footer']['line_item_summary']['info'] = array(
  'quantity' => 'quantity',
  'total' => 'total',
);
/* No results behavior: Global: Text area */
$handler->display->display_options['empty']['area']['id'] = 'area';
$handler->display->display_options['empty']['area']['table'] = 'views';
$handler->display->display_options['empty']['area']['field'] = 'area';
$handler->display->display_options['empty']['area']['content'] = 'Your cart is empty.';
$handler->display->display_options['empty']['area']['format'] = 'filtered_html';
/* No results behavior: Commerce Line Item: Line item summary */
$handler->display->display_options['empty']['line_item_summary']['id'] = 'line_item_summary';
$handler->display->display_options['empty']['line_item_summary']['table'] = 'commerce_line_item';
$handler->display->display_options['empty']['line_item_summary']['field'] = 'line_item_summary';
$handler->display->display_options['empty']['line_item_summary']['info'] = array(
  'quantity' => 'quantity',
  'total' => 'total',
);
/* Relationship: Commerce Order: Referenced line items */
$handler->display->display_options['relationships']['commerce_line_items_line_item_id']['id'] = 'commerce_line_items_line_item_id';
$handler->display->display_options['relationships']['commerce_line_items_line_item_id']['table'] = 'field_data_commerce_line_items';
$handler->display->display_options['relationships']['commerce_line_items_line_item_id']['field'] = 'commerce_line_items_line_item_id';
$handler->display->display_options['relationships']['commerce_line_items_line_item_id']['required'] = TRUE;
/* Field: Commerce Line Item: Line item ID */
$handler->display->display_options['fields']['line_item_id']['id'] = 'line_item_id';
$handler->display->display_options['fields']['line_item_id']['table'] = 'commerce_line_item';
$handler->display->display_options['fields']['line_item_id']['field'] = 'line_item_id';
$handler->display->display_options['fields']['line_item_id']['relationship'] = 'commerce_line_items_line_item_id';
$handler->display->display_options['fields']['line_item_id']['exclude'] = TRUE;
/* Field: Global: Custom text */
$handler->display->display_options['fields']['nothing']['id'] = 'nothing';
$handler->display->display_options['fields']['nothing']['table'] = 'views';
$handler->display->display_options['fields']['nothing']['field'] = 'nothing';
$handler->display->display_options['fields']['nothing']['label'] = '';
$handler->display->display_options['fields']['nothing']['element_label_colon'] = FALSE;
/* Contextual filter: Commerce Order: Order ID */
$handler->display->display_options['arguments']['order_id']['id'] = 'order_id';
$handler->display->display_options['arguments']['order_id']['table'] = 'commerce_order';
$handler->display->display_options['arguments']['order_id']['field'] = 'order_id';
$handler->display->display_options['arguments']['order_id']['default_action'] = 'default';
$handler->display->display_options['arguments']['order_id']['default_argument_type'] = 'commerce_cart_current_cart_order_id';
$handler->display->display_options['arguments']['order_id']['summary']['number_of_records'] = '0';
$handler->display->display_options['arguments']['order_id']['summary']['format'] = 'default_summary';
$handler->display->display_options['arguments']['order_id']['summary_options']['items_per_page'] = '25';
$handler->display->display_options['arguments']['order_id']['validate']['fail'] = 'empty';
/* Filter criterion: Commerce Line Item: Line item is of a product line item type */
$handler->display->display_options['filters']['product_line_item_type']['id'] = 'product_line_item_type';
$handler->display->display_options['filters']['product_line_item_type']['table'] = 'commerce_line_item';
$handler->display->display_options['filters']['product_line_item_type']['field'] = 'product_line_item_type';
$handler->display->display_options['filters']['product_line_item_type']['relationship'] = 'commerce_line_items_line_item_id';
$handler->display->display_options['filters']['product_line_item_type']['value'] = '1';

/* Display: Block */
$handler = $view->new_display('block', 'Block', 'block');
$handler->display->display_options['defaults']['hide_admin_links'] = FALSE;
$handler->display->display_options['defaults']['empty'] = FALSE;
/* No results behavior: Global: Text area */
$handler->display->display_options['empty']['area']['id'] = 'area';
$handler->display->display_options['empty']['area']['table'] = 'views';
$handler->display->display_options['empty']['area']['field'] = 'area';
$handler->display->display_options['empty']['area']['content'] = 'Empty';
$handler->display->display_options['empty']['area']['format'] = 'filtered_html';
/* No results behavior: Commerce Line Item: Line item summary */
$handler->display->display_options['empty']['line_item_summary']['id'] = 'line_item_summary';
$handler->display->display_options['empty']['line_item_summary']['table'] = 'commerce_line_item';
$handler->display->display_options['empty']['line_item_summary']['field'] = 'line_item_summary';
$handler->display->display_options['empty']['line_item_summary']['links'] = array(
  'view_cart' => 0,
  'checkout' => 'checkout',
);
$handler->display->display_options['empty']['line_item_summary']['info'] = array(
  'quantity' => 'quantity',
  'total' => 'total',
);

Make an small module for import this view ?

How it's your oppinion

Update to version Beta 2

FYI, I'm running a vanilla D7 install as well, using the 7.x-1.0-beta2 version of this module (fresh install), and the ajax cart did not work for me out of the box.

I imported the view posted by marameodesign in post #8 and it worked right away.

thanks @marameodesign. Thanks Erik for the module too, good stuff.

New dev Version add default view copied from commerce kick start. Also add a ability to switch view in configuration.

I would like to test this on a stock ("Vanilla") Drupal installation. I have never used Commerce Kickstart so far but instead installed all required modules from scratch. There is another module called Commerce Cart Ajax but that does not work either (see for example #1837356: Cart Block View doesn't refresh) and nobody cares about.

Update

I think this issue is now a Feature request that Needs work.

I'm not the author of this module and even did not try it yet, just thought Support request isn't adequate for an ongoing work announced by the author. Changed the status once again - is it correct now?

I have a feeling the latest release was prematurely. Even when taking into account this module mostly works with Commerce Kickstart. This will embed the Kickstart cart block:

function commerce_ajax_cart_update_block() {
  global $user ;
  $cart_id = commerce_cart_order_id($user->uid);
  print views_embed_view('shopping_cart','block',$cart_id) ;
}

Presumably this should be used more extensively, as it is the choice the user made on the admin page:

variable_get('commerce_ajax_cart_view', COMMERCE_AJAX_CART_DEFAULT_VIEW )

I reckon JS wont work unless the form id of the view gets passed on to the JS through the drupal_add_js function in commerce_ajax_cart_preprocess_html on line #78 of commerce_ajax_cart.module as suggested by #15.

Thoughts?

I threw this together, it works for me but I did it quick and dirty. Could somebody test this and possibly make a patch out of it?
commerce_ajax_cart.js

(function ($) {
  /** Extend ajax commands for update cart block **/
  Drupal.ajax.prototype.commands.commerce_ajax_cart_update = function (ajax, response, status ) {
    window.clearTimeout(Drupal.behaviors.commerce_add_to_cart_show_ajax_cart.timer);
    $.post(Drupal.settings.commerce_ajax_cart.update_url,function(data) {
      jQuery('.view-id-'+Drupal.settings.commerce_ajax_cart.form_id_to_ajax).replaceWith(data) ;
      /** Reattach behaviour **/
      container = jQuery('.view-id-'+Drupal.settings.commerce_ajax_cart.form_id_to_ajax).parent();
      container.unbind('mouseenter').unbind('mouseleave') ;
      Drupal.behaviors.commerce_add_to_cart_show_ajax_cart.attach(container);
      Drupal.behaviors.commerce_add_to_cart_show_ajax_cart.fillCartBlock() ;
      if ( jQuery('.commerce-add-to-cart-confirmation').length > 0 ) {
        var options = { "my" : "center center" , "at" : "center center" , "of" : jQuery(window) };
        jQuery('.commerce-add-to-cart-confirmation').position(options) ;
      }
    }) ;
  }
  Drupal.behaviors.commerce_add_to_cart_show_ajax_cart = {
   timer : 0 ,
   delay : 500,
   fillCartBlock : function() {
     jQuery('a.commerce-ajax-cart-loader').each(function(){
       $.post(Drupal.settings.commerce_ajax_cart.update_url_block,function(data) {
         jQuery('a.commerce-ajax-cart-loader').html(data);
       }) ;
     })
   },
   repositioning : function() {
     var options = {
         "my"        : Drupal.settings.commerce_ajax_cart.position.my,
         "at"        : Drupal.settings.commerce_ajax_cart.position.at,
         "of"        : $('.view-id-'+Drupal.settings.commerce_ajax_cart.form_id_to_ajax).parent(),
         "collision" : Drupal.settings.commerce_ajax_cart.position.collision
       };
     jQuery('#commerce-ajax-cart-preview').position(options) ;
   },
  	attach:function (context, settings) {
     /** Call for chached sites to update block display **/
  	 var container = jQuery(context).find('.view-id-'+Drupal.settings.commerce_ajax_cart.form_id_to_ajax).parent(); 
     jQuery(container).once('commerce-ajax-cart-processed', function() {
       Drupal.ajax.prototype.commands.commerce_ajax_cart_update();
       Drupal.behaviors.commerce_add_to_cart_show_ajax_cart.fillCartBlock(context) ;
     });
     jQuery('#dc-cart-ajax-form-wrapper form').once('commerce-ajax-cart-update',function(){
       jQuery(this).find('a').bind('click',function(){
         Drupal.ajax.prototype.commands.commerce_ajax_cart_update();
       })
     })
     
   		container.bind('mouseenter', function(e) {
   		  window.clearTimeout(Drupal.behaviors.commerce_add_to_cart_show_ajax_cart.timer);
       e.preventDefault();  

       /** Check if preview div is alread created **/
       if ( jQuery('#commerce-ajax-cart-preview').length > 0 ) return ;
       
       /** Append div container **/
       jQuery(this).append('<div class="loading" id="commerce-ajax-cart-preview"><span>Loading</</div>');

       /** Set position for cart preview with jquery.ui.position **/
       //jQuery('#commerce-ajax-cart-preview').position(options) ;
       Drupal.behaviors.commerce_add_to_cart_show_ajax_cart.repositioning() ;
       
       /** Update cart preview **/
       $.post(Drupal.settings.commerce_ajax_cart.ajax_url,function(data) {
         jQuery('#commerce-ajax-cart-preview').removeClass('loading').html(data);
         Drupal.behaviors.commerce_add_to_cart_show_ajax_cart.repositioning() ;
       }) ;
       
     }).bind('mouseleave',function(){
       /** Bind mousehandler for close cart preview **/
       window.clearTimeout(Drupal.behaviors.commerce_add_to_cart_show_ajax_cart.timer);
     	 Drupal.behaviors.commerce_add_to_cart_show_ajax_cart.timer = window.setTimeout(function(){
     	   jQuery('#commerce-ajax-cart-preview').remove();
     	 },Drupal.behaviors.commerce_add_to_cart_show_ajax_cart.delay);
     });
   }
  }
})(jQuery);

Drupal.ajax.prototype.commands.commerceAjaxCartFireTrigger = function(ajax, response, status) {
	jQuery(window).trigger('commerce_ajax_cart_update',response.data)
}

commerce_ajax_cart.module

<?php

define('COMMERCE_AJAX_CART_CACHE_PREFIX', 'commerce_ajax_cart_') ;
define('COMMERCE_AJAX_CART_DEFAULT_VIEW','commerce_cart_block.default');

/**
 * Implement MODULENAME_views_api(),
 */

function commerce_ajax_cart_views_api() {
  return array(	
    'api' => 3,
	  'path' => drupal_get_path('module', 'commerce_ajax_cart') . '/includes/views',
  );
}

/**
 * Implements hook_menu().
 */
function commerce_ajax_cart_menu() {
  $items['cart/ajax'] = array(
    'page callback'    => 'commerce_ajax_cart_show_contents',
    'access callback'  => 'commerce_ajax_validate_post_request',
    'type'             => MENU_CALLBACK
  ) ;
  $items['cart/ajax/update'] = array(
    'page callback'    => 'commerce_ajax_cart_update_block',
    'access callback'  => 'commerce_ajax_validate_post_request',
    'type'             => MENU_CALLBACK
  ) ;
  $items['cart/ajax/block'] = array(
    'page callback'    => 'commerce_ajax_cart_show_contents_block',
    'access callback'  => 'commerce_ajax_validate_post_request',
    'type'             => MENU_CALLBACK
  ) ;
  $items['admin/commerce/config/advanced-settings/ajax-cart'] = array(
    'page callback'    => 'drupal_get_form',
    'page arguments'   => array('commerce_ajax_cart_settings_form'),
    'file'             => 'commerce_ajax_cart.admin.inc' ,
    'title'            => 'Commerce ajax cart settings',
    'access arguments' => array('configure store'),
    'type' => MENU_NORMAL_ITEM
  ) ;
  return $items ;
}

function commerce_ajax_cart_get_defaults() {
  return array(
    'my' => 'left top',
    'at' => 'left bottom',
    'collision' => ''
  );
}

function commerce_ajax_cart_preprocess_block(&$variables) {
  if ( 'commerce_cart' == $variables['block']->module && $variables['block_id'] == 1) {
    $variables['content'] = l( '<span>'. t('Show cart').'</span>' , 'cart' ,array( 'html' => true, 'attributes' => array('class' => array('commerce-ajax-cart-loader'))));
  }
}

function commerce_ajax_cart_show_contents_block() {
  $content = commerce_cart_block_view('cart') ;
  print $content['content'] ;
}

function commerce_ajax_validate_post_request() {
  if ( strtolower($_SERVER['REQUEST_METHOD']) !== 'post' ) {
    drupal_goto('cart');
  }
  return true ;
}

function commerce_ajax_cart_preprocess_html() {
  $defaults = variable_get('commerce_ajax_cart_position',commerce_ajax_cart_get_defaults()) ;
  drupal_add_library('system', 'ui.position');
  drupal_add_js('misc/ajax.js',array('type' => 'file' , 'weight' => -100 ));
  drupal_add_js( drupal_get_path('module','commerce_ajax_cart') . '/js/commerce_ajax_cart.js',array('type' => 'file', 'scope' => 'footer' , 'weight' => 100 ));
  $commerce_ajax_cart_view = explode(".", variable_get('commerce_ajax_cart_view', COMMERCE_AJAX_CART_DEFAULT_VIEW ));
  drupal_add_js(array('commerce_ajax_cart' => array(
                      'position' => $defaults,
                      'form_id_to_ajax' => $commerce_ajax_cart_view[0],
                      'update_url' => url('cart/ajax/update'),
                      'update_url_block' => url('cart/ajax/block'),
                      'ajax_url' => url('cart/ajax'),
                      'text' => t(variable_get('commerce_ajax_cart_text', 'There is no product in your cart' )) )),
                'setting') ;
}

/**
 * Page callback for show cart contents
 */
function commerce_ajax_cart_show_contents() {
  global $user ;
  $cart_id = commerce_cart_order_id($user->uid);
  $cid = COMMERCE_AJAX_CART_CACHE_PREFIX . $cart_id ;
  if ( FALSE !== ($cache = cache_get($cid,'cache')) ) {
    print $cache->data; 
  } else {
    $commerce_ajax_cart_view = explode(".", variable_get('commerce_ajax_cart_view', COMMERCE_AJAX_CART_DEFAULT_VIEW ));
    $view = views_get_view($commerce_ajax_cart_view[0]);
    $view->set_arguments(array($cart_id)) ;
    $output = $view->execute_display() ;
    if ( !$view->result || count($view->result) == 0 ) {
      $output = '<div class="empty-cart">' . variable_get('commerce_ajax_cart_text', 'There is no product in your cart' ) . '</div>' ;
    }
    cache_set($cid, $output, 'cache', CACHE_TEMPORARY) ;
    print $output;
  }
}

/**
 * Page callback for update cart block
 */

function commerce_ajax_cart_update_block() {
  global $user ;
  $cart_id = commerce_cart_order_id($user->uid);
  $commerce_ajax_cart_view = explode(".", variable_get('commerce_ajax_cart_view', COMMERCE_AJAX_CART_DEFAULT_VIEW ));
  print views_embed_view($commerce_ajax_cart_view[0], $commerce_ajax_cart_view[1], $cart_id);
}

/**
 * Implements hook_entity_info_alter().
 *
 * Create new view mode for product display, commerce product.
 */
function commerce_ajax_cart_entity_info_alter(&$entity_info) {
  $view_mode = array('commerce_product_in_cart' => array(
    'label' => t('Cart view mode'),
    'custom settings' => TRUE,
  ));
  $entity_info['commerce_line_item']['view modes'] += $view_mode ;
  $entity_info['commerce_product']['view modes'] += $view_mode ;
}

/**
 * Implements hook_form_FORM_ID_alter().
 */
function commerce_ajax_cart_form_commerce_cart_add_to_cart_form_alter(&$form, $form_state, $form_id) {
  $form['submit']['#ajax'] = array(
    'callback' => 'commerce_ajax_cart_callback',
  );
}

function commerce_ajax_cart_callback($form, &$form_state){
  global $user;

  $form = drupal_rebuild_form($form['#form_id'], $form_state, $form);

  $commands = array();
  $commands[] = array('command' => 'commerce_ajax_cart_update') ;
  $commands[] = ajax_command_prepend('#block-system-main', theme('status_messages'));
  $commands[] = ajax_command_replace('.' . drupal_html_class($form['#form_id']), drupal_render($form));
  $commands[] = array(
  	'command' => 'commerceAjaxCartFireTrigger',
  	'data'    => $form['#form_id'] 
  );

  return array('#type' => 'ajax', '#commands' => $commands);
}
/**
 * Implement hook_boost_is_cacheable
 *
 * @param unknown $parts
 * @param string $request_type
 * @return boolean
 */
function commerce_ajax_cart_boost_is_cacheable($parts, $request_type = 'normal') {
  global $user;
  $urlParts = explode('/', $parts['normal_path']) ;
  if ( isset($urlParts[0]) && isset($urlParts[1]) && $urlParts[0] == 'cart' ) {
    if ( $urlParts[1] == 'ajax' ) {
      $parts['is_cacheable'] = FALSE;
      $parts['is_cacheable_reason'] = 'Do not cache cart update urls.';
    }
  } else {
    $parts['is_cacheable'] = TRUE;
  }
  return $parts;
}

function commerce_ajax_cart_entity_update($entity, $type) {
  if ( $type != 'commerce_order' ) return ;
  if ( $entity->status != 'cart' ) return ;
  $cid = COMMERCE_AJAX_CART_CACHE_PREFIX . $entity->order_number ;
  cache_clear_all($cid,'cache') ;
  commerce_ajax_cart_generate_cache($entity->order_number);
}

function commerce_ajax_cart_entity_delete($entity, $type) {
  if ( $type != 'commerce_order' ) return ;
  $cid = COMMERCE_AJAX_CART_CACHE_PREFIX . $entity->order_number ;
  cache_clear_all($cid,'cache') ;
}

function commerce_ajax_cart_generate_cache($cart_id) {
  $cid = COMMERCE_AJAX_CART_CACHE_PREFIX . $cart_id ;
  $commerce_ajax_cart_view = explode(".", variable_get('commerce_ajax_cart_view', COMMERCE_AJAX_CART_DEFAULT_VIEW ));
  $view = views_get_view($commerce_ajax_cart_view[0]);
  if ( !$view ) {
  	$output = t('Please configure view settings for ajax cart @link',array('@link' => l('Settings','admin/commerce/config/advanced-settings/ajax-cart') ) );
  	cache_set($cid, $output, 'cache', CACHE_TEMPORARY) ;
  	return;
  }
  $view->set_arguments(array($cart_id)) ;
  $output = $view->execute_display() ;
  if ( !$view->result || count($view->result) == 0 ) {
    $output = '<div class="empty-cart">' . variable_get('commerce_ajax_cart_text', 'There is no product in your cart' ) . '</div>' ;
  }
  cache_set($cid, $output, 'cache', CACHE_TEMPORARY) ;
}

commerce_ajax_cart.admin.inc

<?php

function commerce_ajax_cart_settings_form() {
  $defaults = variable_get('commerce_ajax_cart_position',commerce_ajax_cart_get_defaults()) ;
  
  $views = views_get_enabled_views();
  $view_settings = array();
  foreach ( $views as $view_id => $view ) {
  	if ( $view->base_table == 'commerce_order' ) {
      foreach ($view->display as $display_id => $display) {
        $view_settings[$view_id.".".$display_id] = $view->human_name . ' (' . $view->name . '.' . $display_id .') ' ;
      }
  	}
  }

  $form = array();
  $form['position'] = array(
    '#type' => 'fieldset',
    '#tree' => true ,
    '#title' => t('Positioning of cart preview'),
    '#description' => t('Read documentation for jquery_ui position <a target="_blank" href="http://api.jqueryui.com/position/">here</a>')
  );
  $form['position']['my'] = array(
  	'#type' => 'textfield',
    '#title' => 'my',
    '#default_value' => $defaults['my']
  );
  $form['position']['at'] = array(
    '#type' => 'textfield',
    '#title' => 'at',
    '#default_value' => $defaults['at']
  );
  $form['position']['collision'] = array(
    '#type' => 'textfield',
    '#title' => 'collision',
    '#default_value' => $defaults['collision']
  );

  $form['empty'] = array(
  	'#type' => 'textfield',
    '#title' => t('Empty cart text'),
    '#default_value' => variable_get('commerce_ajax_cart_text', 'There is no product in your cart' )
  );
  
  $form['view'] = array(
  		'#type' => 'select',
  	  '#options' => $view_settings, 
  		'#title' => t('Shopping cart to use'),
  		'#default_value' => variable_get('commerce_ajax_cart_view', COMMERCE_AJAX_CART_DEFAULT_VIEW )
  );

  $form['actions'] = array();
  $form['actions']['submit'] = array(
  	'#type' => 'submit',
    '#value' => t('Save settings'),
  );

  return $form ;
}

function commerce_ajax_cart_settings_form_submit($form,$form_state) {
  variable_set('commerce_ajax_cart_position',$form_state['values']['position']) ;
  variable_set('commerce_ajax_cart_text',$form_state['values']['empty']) ;
  variable_set('commerce_ajax_cart_view',$form_state['values']['view']) ;
}

I guess I'll update this.

It doesn't work for an empty cart
I added this on line #7:
jQuery('.cart-empty-block').replaceWith(data) ;
I'm sure it can be made fancier.

Is there anyone working on getting the module to work with a non kickstart installation?

#ppelgrims: I think if you would provide your suggested changes as a patch, people would be able to easily test them.

Thanks.

@roball I have zero experience making patches, but I'll try to look into it this week.

@ppelgrims: see https://drupal.org/patch

I hope this works.

@ppelgrims thanks for the patch.

When you make the patch you should have it relative to this module. You can do that in your project by using git diff --relative . gtv3 looks like it snuck into the changes which looks like a custom module you've created and the patch is relative to the drupal root and not the module's root so that's why that got picked up too. Those 2 things are why the patch is failing.

I've bumped the version to dev because the patch should be against the latest dev. This is so that testbot knows which version of the module you are patching against and I'm assuming you are trying to patch the latest to get it committed and the maintainer will apply the patch then roll that into beta4 with any luck.

Have a quick view of the coding standards https://drupal.org/coding-standards.
It looks like you are using tabs instead of 2 spaces.

Good first try though! It's a patch, it's a valid and the naming convention is spot on:)

Hope that helps, give'r another roll:)

Thanks for being so kind and clearing that out Joel! Using the --relative parameter got rid of the other module as well.

Converted tabs to spaces, line endings are still Unix.

It's saying it doesn't apply. Which means it may not be made against. 1.x-dev

I tried the patch against 7.x-1.x (dev/master) and 7.x-1.0-beta3 and it doesn't seem to apply. What version do you have locally that you are patching against?

To get dev/master or all the branches you can clone it down:

git clone --branch 7.x-1.x http://git.drupal.org/project/commerce_ajax_cart.git
cd commerce_ajax_cart

But the way you are doing it should also work with drush dl commerce_ajax_cart --dev
Though sometimes they are out of sync that usually does the trick when you use --relative in your project. Cloning like above can make a mess of your project's git repo (because it would need to become a git submodule), but you could do it temporarily:)

Anyways that patch is looking much better. There is some 3 spaces in a couple places where there should be just 2, but I'll let that slide till it goes green:)

I started over following this. Fingers crossed!

Awesome @ppelgrims just tried it out and it seems to work great. There are some coding standards things to fix before it can be marked at RTBC and it would be nice to have someone else give this a try too!

@ppelgrims, do you mind updating the issue summary and title to to reflect what that code does because the original title and IS are not clear? And if it's cool with you I'll give you another nit picky code review to help get things up to snuff?

If you are using sublime text to edit code there is a nice little settings here that will do half the nitpicky things I'd ask you to do anyway. https://drupal.org/node/1346890 The sidebar has settings/configs for other IDE/editors too. That way the code reviews are are easier to see the forest for the trees ;)

Erik looks busy at the moment but if we give him no reason to hold this back I'm sure he'll commit it. Or I'll put my name on this help wanted list and I will:) @see #2258475: Help / Co Maintainer wanted

Was playing around with this also and realized that there was something wrong still even though this fixed a good chunk(seems like the fix comes from the form_id stuff in the patch. There is a discrepancy in which view is being updated for the add to cart button and hovered over. And which view is to show up through ajax on hover.

+++ b/commerce_ajax_cart.module
@@ -105,7 +107,8 @@ function commerce_ajax_cart_show_contents() {
-    $view = views_get_view('commerce_cart_block');
+    $commerce_ajax_cart_view = commerce_ajax_cart_get_view();
+    $view = views_get_view($commerce_ajax_cart_view[0]);

@@ -123,7 +126,9 @@ function commerce_ajax_cart_show_contents() {
-  print views_embed_view('shopping_cart','block',$cart_id) ;
+  $commerce_ajax_cart_view = commerce_ajax_cart_get_view();
+  $path_alias = drupal_lookup_path('alias', current_path() );
+  print views_embed_view($commerce_ajax_cart_view[0], $commerce_ajax_cart_view[1], $cart_id, $path_alias );

These changes make the block that is being added via the popup window use the same block that is being displayed/updated etc.

I have the JS for that commented out as I don't need the hover. It would make more sense to have an option to switch off the feature now that I think about it. I'm not sure what's wrong or needs to happen?

This version of the module didn't work out of the box with a cart that wasn't provided by Commerce Kickstart. #8 provided the code of said cart to import into a vanilla Commerce installation.
What my patch does is fix the ability to switch views in the backend, which was introduced in #12, I wrote a small summary in #21.

Re: coding standards, I thought cleaning up code should be a different commit?

@ppelgrims, you are right about code cleanup being a different commit BUT not on your changes. You shouldn't introduce new coding standard issues to the pile of them.

Can you add that message to the issue summary?

This version of the module didn't work out of the box with a cart that wasn't provided by Commerce Kickstart. #8 provided the code of said cart to import into a vanilla Commerce installation.
What my patch does is fix the ability to switch views in the backend, which was introduced in #12, I wrote a small summary in #21.

I've got a patch that helps get the hover working too. Mind if I post with an interdiff against #40? I'll include the coding standards changes too.

Do it! :)

It's hard for me not to fix the coding standards issues too:( Hopefully the interdiff isn't too useless...

+++ b/commerce_ajax_cart.module
@@ -77,6 +77,7 @@ function commerce_ajax_cart_preprocess_html() {
+                      'form_id' => 'shopping_cart_cac',

@@ -123,7 +124,7 @@ function commerce_ajax_cart_show_contents() {
-  print views_embed_view('shopping_cart','block',$cart_id) ;
+  print views_embed_view('shopping_cart_cac', 'block', $cart_id);

The big difference is that there is a view that comes with this module which seems to be the top view in this project page's screenshot form kickstart.

It's the one that gets auto updated via the commerce_ajax_cart_update_block(). So instead of using the same block for both, I opted for now to just use the shopping_cart_cac Views block that comes with the module as the main block that get's updated. And the one that you choose through the UI I left with the nice code you wrote to hook up the views + display options in #40. Also note that shopping_cart' view doesn't exist, so that could be why things didn't work so well before...

That should be more clear than that crappy interdiff I did there... I need to stop cleaning doc standards in patches:(

How does that sit with you @ppelgrims?

@ppelgrims I'm co-maintaining this project now. I've cleaned up the majority of the coding standards on the dev branch. So now this set of changes should be much clearer to review.

Please read through, and give it a go and we can continue from there.

I hope I didn't miss anything from your patch. Though I do want to try to keep the scope of this change as succinct as possible.

Just to summarize what this does:

1. Shows the displays as well as the views that have a 'commerce_order' base table for the list.
2. Fixes the title on the views list, previously 'Empty Cart Text' duplicated from the label above now reads 'Shopping Cart to Use'.
3. 'Shopping Cart to Use' is the view block defaulted to 'commerce_cart_block.default' view from the commerce_cart module.
4. The view that comes with this module provides the block that get's updated (this was fixed and left as is to hopefully prevent upgrade breaks) as this should still work with commerce kickstart and look like it does on the project page.

This should get it work with Drupal Commerce and continue to work with Commerce Kickstart.
We should likely see if we can provide a feature in another issue to allow the updated view block (shopping_cart_cac) be an option to change, though I'd consider that to be followup territory, along with confirmation message thing that mentioned in the issue summary.

I get Uncaught TypeError: undefined is not a function referring to commerce_ajax_cart.js line 50. My version is 7.x-1.0-beta3+3-dev

@RgnYLDZ is that with this patch applied or should you've opened a new issue for that bug report?

I got this working on an old project (via #8). so in this project I directly installed and applyed the patch, no luck. I'll do another project with commerce in the near future. I'll get back with more details. I really have a deadline.

And thank you for improving this module.

Hello, guys! Thank you for working on this :)

I tested patch #48 on a project based on a raw Drupal Commerce. The default add to cart block view was already altered and themed. I've found a problem using a module with a patch due to hardcoded usage of view shopping_cart_cac which this module provides.

joelpittet, I've seen your comment about this is planned to be fixed in separate issue. Let me just leave the patch here for future reference. It is based on #48, rerolled against head and containing some additional code to fully support view change setting.

I found that commerce_add_to_cart_confirmation module works nice in pair with this module for confirmation message.

I also need to disable cart details on hover, so an option would be nice.

Until this get fixed , it would be nice to mention on module page that it is currently working with commerce kickstart only and linking this issue.

i got this working using non kickstart install using the current dev version of this module with the patches

projects[commerce_ajax_cart][patch][] = https://www.drupal.org/files/issues/default_values-2292641-1.patch
projects[commerce_ajax_cart][patch][] = https://www.drupal.org/files/issues/causes_jquery_errors-2280465-6.patch
projects[commerce_ajax_cart][patch][] = https://www.drupal.org/files/issues/2147697-53-cart-views-refactor.patch

then setting the correct block in the config form and boom!

Sorry for the late reply:( I've committed the patches mentioned in #55 to dev. So it's just this one.

@sin regarding #53 that looks pretty nice. An interdiff goes a long way to see what has changed. That feature request is actually something I was looking for too and I was thinking that should be a new block... the reason being so we don't do extra work rendering a view that is never displayed. Could you open a new feature request?

I've committed #53 with the indexes changed to an assosiative array to make it easier to tell what it's doing.

Thank you joelpittet for the commit. I think this deserves a new beta release.

@roball I'll give it a week or two but yeah I agree. If people find it's working as it should we'll look at a new release.

Thank you joelpittet for your work!
I'll try to test current dev till the end of the year :)
Added a feature request #2398319: An option to disable cart details on hover.

What about pushing out the new beta soon (meanwhile, 2 months have passed since this issue has been fixed)?

Sorry for the delay, I've tested current dev with our custom Commerce Distribution based on current Drupal Commerce release 1.11. The module works great with default settings! :)

Just tested with custom cart block view, works as expected.